Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-capital=yes values #522

Closed
pnorman opened this issue May 15, 2014 · 6 comments · Fixed by #1247
Closed

Non-capital=yes values #522

pnorman opened this issue May 15, 2014 · 6 comments · Fixed by #1247
Labels
code placenames
Milestone
Bugs and improvem...

Comments

@pnorman
Copy link
Collaborator

pnorman commented May 15, 2014

We currently check for capital='yes' on #placenames-capital, but this doesn't match capital=4. We should probably check either for capital = ANY (ARRAY['1','2','3','4','yes']) or capital IS NOT NULL AND capital != 'no'

(note: is the NOT NULL check necessary, or implied by the inequality check?)
@pnorman pnorman added the code label May 15, 2014
pnorman added a commit to pnorman/openstreetmap-carto that referenced this issue May 15, 2014
@pnorman
Combine the two medium place layers
1b788bf 
Previously we had one place layer for capitals and one for non-capitals
when it came to towns and cities. This combines them, reducing the number
of queries, making the SQL simpler, and making the layers more useful for
other styles.

Incidentially fixes gravitystorm#522
@dieterdreist
Copy link

agree. Would prefer the numbers-variant (allows for automatic evaluation of
the hierarchy). Suggest to extend the array of values with 5 and 6.

@lest69
Copy link

lest69 commented May 15, 2014

I can agree with including down to 6, because that includes districts or regions that could still have a capital. Definitely not lower, though.
On a related note, I'm confused why 85% of the use of this tag is with the value 8. For most countries, admin_level=8 corresponds to a city/town/village. How on earth can you have a capital of a city? Maybe it's being misused as a tag for the admin_centre?

@matthijsmelissen
Copy link
Collaborator

There is also a long discussion on this topic on the talk mailing list now. Maybe @dieterdreist can liaise?

@dieterdreist
Copy link

Am 15/mag/2014 um 22:24 schrieb math1985 [email protected]:

Maybe @dieterdreist can liaise?

yes, it's used to mark the administrative importance / the main place for an administrative entity.

@pnorman pnorman mentioned this issue May 20, 2014
Closed
@matthijsmelissen
Copy link
Collaborator

capital = ANY (ARRAY['1','2','3','4','yes'])

@pnorman Does this differ from capital IN ('1','2','3','4','yes')?

@pnorman
Copy link
Collaborator Author

pnorman commented Sep 26, 2014

@pnorman Does this differ from capital IN ('1','2','3','4','yes')?

capital = ANY (ARRAY['1','2','3','4','yes'])

The query planner will optimize IN to a = ANY check

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Jan 21, 2015
@matthijsmelissen
Clean up place name rendering
c1dcd0d 
* Don't render place=town on z16 and higher, and place=suburb and place=village
  on z17 and higher.
* Render place=hamlet, place=locality, place=neighbourhood, place=quarter,
  place=isolated_dwelling, and place=farm from z15 rather than from z14
  (resolves gravitystorm#948).
* Render place=town black rather than gray.
* Make font sizes more consistent by increasing font size for place=town on z12
  and z13, for place=suburb on z16, and for place=village on z14 and z16
  (resolves gravitystorm#734, resolves gravitystorm#1204).
* Add rendering for place=block and place=city_block (resolves gravitystorm#107).
* Add rendering for place=quarter (like place=neighbourhood) and place=borough
  (like place=suburb, resolves gravitystorm#798).
* Treat capital=4 like capital=yes (resolves gravitystorm#522).
* Make text-wrap consistent.
@matthijsmelissen matthijsmelissen mentioned this issue Jan 21, 2015
Merged
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Jan 30, 2015
@matthijsmelissen
Clean up place name rendering
dd356c9 
* Don't render place=town on z16 and higher, and place=suburb and place=village
  on z17 and higher.
* Render place=hamlet, place=locality, place=neighbourhood,
  place=isolated_dwelling, and place=farm from z15 rather than from z14 (resolves
  gravitystorm#948).
* Render place=town black rather than gray.
* Make font sizes more consistent by increasing font size for place=town on z12
  and z13, for place=suburb on z16, and for place=village on z14 and z16
  (resolves gravitystorm#734, resolves gravitystorm#1204).
* Treat capital=4 like capital=yes (resolves gravitystorm#522).
* Make text-wrap consistent.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Feb 4, 2015
@matthijsmelissen
Clean up place name rendering
e19da84 
* Don't render place=town on z16 and higher, and place=suburb and place=village
  on z17 and higher.
* Render place=hamlet, place=locality, place=neighbourhood,
  place=isolated_dwelling, and place=farm from z15 rather than from z14 (resolves
  gravitystorm#948).
* Render place=town black rather than gray.
* Make font sizes more consistent by increasing font size for place=town on z12
  and z13, for place=suburb on z16, and for place=village on z14 and z16
  (resolves gravitystorm#734, resolves gravitystorm#1204).
* Treat capital=4 like capital=yes (resolves gravitystorm#522).
* Make text-wrap consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code placenames
Projects
None yet
Milestone
Bugs and improvements
4 participants
@dieterdreist @pnorman @matthijsmelissen @lest69