-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ogr2ogr dependency #50
Comments
This was fixed in mapnik/mapnik#1605 (comment) but we'd have to bump the required version to 2.2, which hasn't yet been released. This would also impact #45 but because ogr2ogr is warning about encodings we should check that the rendered result gets it right before dropping ogr2ogr. Hosting a fixed version would of course render the issue moot |
If hosting a fixed version we should strip out unnecessary shapefile fields to save space. Have we contacted NE to ask about getting them to fix the issues? |
@pnorman, natural earth maintainer was hired by apple, so "we" are all natural earth maintainers now. |
Created a NaturalEarth Correction ticket (UA3125RX4Z) as that seems to be the only way on their site. If we get no response, I guess we'll have to look at hosting a fixed version on planet.osm.org or somewhere? |
@pnorman if mapnik 2.2 is fixed does that mean we can skip the ogr2ogr step on the production servers which are using 2.2? |
My reading of git is that mapnik/mapnik@913e1d0 is in 2.2.0 but I'm not 100% confident. Also I haven't tested. So almost certainly, but a slim chance of a problem. |
That commit is in 2.2.0 yes. |
Well, since this seems to not be an option, how about hosting a fixed one on planet.osm.org? I know it's not ideal, but neither is requiring ogr2ogr or mapnik 2.2. On the other hand, if andy is planning on introducing features that require mapnik 2.2 then we can drop ogr2ogr when the minimum mapnik version is upgraded |
One other option is to use |
Given that we only need it for one minor task, we should remove the ogr2ogr dependency from the setup. It's not too bad on linux systems (yay package management) but it's an unnecessary hurdle elsewhere.
If we can't get the NE shapefile fixed upstream, then lets host a fixed version of the file somewhere and grab it from there instead.
The text was updated successfully, but these errors were encountered: