-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render names on natural=reef
#4898
Comments
Thanks for the suggestion. Currently 3149 of 47176 Not all of these feature actual names of the reefs though - in particular there are quite a few which carry the names of Atolls/Islands the reefs are part of or surrounding. Like: https://www.openstreetmap.org/relation/3975771 So far none of the examples shown seems to be a valid case of a named
That does not mean there are no Based on what i can see so far i would in particular like to see us rendering |
I disagree that those examples are invalid, except for the third which I only included to show a reef next to a different named My main reasoning for Not rendering names on Rendering names on Considering that there have been no updates to the |
For better understanding: We generally do not consider past decisions in the style authoritative. Our understanding of the map and its influence on mapping practice develop over time - as does actual mapping practice. We try to learn from that and adjust our decisions accordingly. Design of the map needs to maintain visual consistency of course, but the argument that because you are rendering A you also have to render B is not something we tend to subscribe to (not to mention that it also works the other way - we don't render B so we should also stop rendering A). My comments are not meant to express that i am against rendering name labels for My recommendation to developers who consider working on this: Look at implementing rendering of |
I vaguely remembered that we at one time had reef labels rendered - and indeed - this was removed unintentionally and without discussion in #3712, we still have the mss code for this: openstreetmap-carto/style/amenity-points.mss Line 2202 in fe6fd98
openstreetmap-carto/style/amenity-points.mss Line 2232 in fe6fd98
So this is actually a regression and a change made without consensus. That does not change the analysis i provided above - but it puts this into a different context (i.e. that we had consensus to add this back in 2015 - see #1990). |
As someone who knows the area, Black Middens is quite correctly tagged as a reef. Reefs can be in the inter-tidal zone. The wiki has the helpful caveat "However note that small parts of reefs may be exposed at low tide, but not the entire feature. Reefs are never exposed at high tide.", i.e. a reef is essentially a upwards rock feature, distinguishing it from flatter features, Given that we map the oceans at high water, the current tagging seems perfectly good. On the other hand, isn't Tice's Shoal is more likely to a .... shoal? |
No tagging discussion here please. This issue is about rendering name labels on What we are rendering My view on this issue is that since the removal of label rendering of these was unintentional and undiscussed i would support re-introducing that to the previous state. A re-evaluation if the name tag is consistently used on Please do not forget that - as i pointed out - the fraction of |
For most
natural
areas that are currently rendered, when they have a name, the name is rendered. However, this isn't the case fornatural=reef
areas. It would make sense for their name to be rendered, to be more consistent with othernatural
areas.Examples of named reefs:

Black Middens, z19 (https://www.openstreetmap.org/way/723976781)
Bikini Atoll, z12 (https://www.openstreetmap.org/relation/3973841)

Tices Shoal, z16 (https://www.openstreetmap.org/way/601883648), next to Island Beach, a named

natural=beach
area where the name is rendered (https://www.openstreetmap.org/relation/10948497)The text was updated successfully, but these errors were encountered: