Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rendering of leisure=recreation_ground (synonym of landuse=recreation_ground) #4572

Closed
jeisenbe opened this issue Jun 8, 2022 · 11 comments · Fixed by #4593
Closed

Comments

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jun 8, 2022

leisure=recreation_ground is a less common synonym of landuse=recreation_ground

https://taginfo.openstreetmap.org/compare/landuse=recreation_ground/leisure=recreation_ground

I believe leisure=recreation_ground was added as a mistake in 2009 based on the history graph, and it has been strongly declining for several years now

https://taghistory.raifer.tech/#***/leisure/recreation_ground&***/landuse/recreation_ground

Screen Shot 2022-06-08 at 10 00 02

@imagico
Copy link
Collaborator

imagico commented Jun 8, 2022

That is definitely a good idea. I would go a steps further and suggest to also drop rendering of landuse=recreation_ground as this is used essentially as an umbrella tag for leisure=park, leisure=sport_centre, leisure=water_park and leisure=playground. Doing so would encourage and support mappers to use the semantically more precise tags.

@zekefarwell
Copy link

I would go a steps further and suggest to also drop rendering of landuse=recreation_ground

It certainly is a bit of a catchall tag, the usage of which has strayed from the original intent. However I doubt removing rendering for it will improve the situation. Clearly there are many recreation areas where mappers consider leisure=park and leisure=sport_centre innappropriate, but landuse=recreation_ground close enough. Removing rendering for this tag will probably just annoy people and not improve the situation much. Adding rendering for more specific recreation area tags sounds great. For example, adding support for landuse=winter_sports would be good as that would encourage mappers to stop using landuse=recreation_ground for ski areas.

@boothym
Copy link
Contributor

boothym commented Jun 11, 2022

I cannot see a reason why both leisure and landuse need to be rendered when there is no difference in meaning between the tags. The change would certainly fit in with the goals of the style, namely "... and helps to prevent unfavorable fragmentation of tag use."

iD already suggests "upgrading" the leisure tag to landuse, so it will likely continue to fall anyway.

@Adamant36
Copy link
Contributor

Adamant36 commented Jun 14, 2022

I would go a steps further and suggest to also drop rendering of landuse=recreation_ground as this is used essentially as an umbrella tag for leisure=park, leisure=sport_centre, leisure=water_park and leisure=playground.

From what I've seen, that seems to be the case in most of a California and some other states. I use to have the opinion that leisure=park shouldn't be used in more ambiguous situations where landuse=recreation_ground would make more sense, but that doesn't seem to be the consensus in the United States. Mostly American's just want to tag everything even slightly related to recreation as a park. The fact that landuse=recreation_ground is also render has led to a lot of needless miss-tagging, edit waring, and bad blood in the meantime. So personally I'd support not rendering it anymore. Even if such issues didn't exist I can't think of a situation where leisure=park, leisure=sport_centre, leisure=water_park, leisure=pitch, or one of the many other tags that essentially cover the same concept wouldn't work better anyway.

@DaveF63
Copy link

DaveF63 commented Jul 17, 2022

Here are my thoughts on this subject from a discussion on the Tagging forum.

Is landuse=recreation_ground different than leisure=park

Specific to this actual issue:

I've never understood why recreation ground is tag with the key
'landuse'.
Given the close association of other leisures features such as pitch
park, playground, picnic table, seating, dog park etc I firmly believe it should also
be tagged as leisure.

The official name containing either 'recreation ground' & 'park' also
has a bearing.

Using landuse for recreation_ground allows duplicating tags to use 'leisure'.
These are both primary tags, designed to be used in isolation. It causes conflicts so should not be used together.

way[leisure=park][landuse]

recreation_ground is used essentially as an umbrella tag.

Contributors' failure to understand the purpose of a tag is not a reason to rescind it.

@LaoshuBaby
Copy link

landuse=recreation_ground as this is used essentially as an umbrella tag for leisure=park, leisure=sport_centre, leisure=water_park and leisure=playground.

I was confused by this, is park located in a recreation_ground?

@imagico
Copy link
Collaborator

imagico commented Jul 19, 2022

landuse=recreation_ground as this is used essentially as an umbrella tag for leisure=park, leisure=sport_centre, leisure=water_park and leisure=playground.

I was confused by this, is park located in a recreation_ground?

The term 'umbrella tag' is not meant geometrically, it refers to the classification semantics. The tag landuse=recreation_ground is used for a broad range of real world structures that are more commonly mapped in OSM with the more narrow and semantically more specific tags mentioned.

Note that - as always in the context of OSM-Carto - i am talking about the de facto meaning of tags in their use by mappers world wide, not about the meaning of the terms used for key and value in a certain English language cultural context. So i am not claiming that anywhere in the world the term 'park' and the term 'recreation_ground' have an overlapping or even similar meaning.

One of our main goals is to support mappers in consistent use of tags and to render things in a way that prevents unfavorable fragmentation of tag use. And it is usually consensus among the maintainers that this goal speaks against rendering synonyms and umbrella tags. Ceasing to render landuse=recreation_ground would be in line with that.

I can understand and i sympathize with native and fluent English speakers who consider a recreation ground to be something well defined or at least something as well defined as a park or a sport centre and who would therefore like to see landuse=recreation_ground (or leisure=recreation_ground) to be used with that meaning and also being rendered here accordingly. Unfortunately the reality of mapping does not provide a solid basis for that.

@DaveF63
Copy link

DaveF63 commented Jul 20, 2022

this is used essentially as an umbrella tag

It's an individual feature in it's own right. In the real world & within OSM.
OSM-carto reinterpreting reality to suit their world is a problem for OSM-carto contributors to rectify.

for leisure=park, leisure=sport_centre, leisure=water_park and leisure=playground

Again. removing a valid tag just because some (US?) contributors fail to understand is a really poor idea.

Substituting all those leisure features for a landuse feature shows why recreation_ground should be a part of the leisure key family.

the maintainers are against rendering umbrella tags.

natural=water <cough>

@Adamant36
Copy link
Contributor

Adamant36 commented Jul 21, 2022

Removing a valid tag just because some (US?) contributors fail to understand is a really poor idea.

Not like the reverse hasn't happened where a tag wasn't rendered just because some (German?) contributors failed to see the tags usefulness and thought it was someone's pet project. amenity=parcel_locker < cough cough >, but sure the style should keep rendering an ambiguous umbrella tag because "who cares about American contributors 🤮" or whatever.

@DaveF63
Copy link

DaveF63 commented Jul 21, 2022

It's only "ambiguous" to those why fail to comprehend its meaning. This lack of knowledge & "umbrella" misuse within OSM is not a reason for OSM-carto to make unilateral decisions on a tags usage.

@Adamant36
Copy link
Contributor

It's only "ambiguous" to those why fail to comprehend its meaning.

You can say that for anything though. In this case the article for landuse=recreation_ground says it's used for "An open space for general recreation" and the article for leisure=park says "A park is an area of open space for recreational use." Maybe it's just because I'm an ignorant American or whatever, but I don't know how anyone can reasonably argue that landuse=recreation_ground isn't a pointless umbrella tag when it has literally the exact same definition as leisure=park, but with only 1/10th the usage. Hell, the image used on the landuse=recreation_ground article is exactly the same as the one for leisure=fitness_station and even there looking at 1/5th the usage landuse=recreation_ground when compared to the competing tag.

But forget all that though and just look at the usage trends for all three tags. There's clearly a "winner" there and it isn't landuse=recreation_ground. If anything the tag is on the decline compared to the other tags. Especially leisure=park. So your really fighting a losing battle. The style might as well just stop rendering the tag and be done with it. Or I guess you can yell into the wind about stupid Americans or whatever while the tag's usage continues to decrease and it's eventually removed anyway.

Tag usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants