Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render abandoned:building=* #4238

Closed
wielandb opened this issue Oct 28, 2020 · 3 comments
Closed

Render abandoned:building=* #4238

wielandb opened this issue Oct 28, 2020 · 3 comments
Labels
buildings declined new features Requests to render new features

Comments

@wielandb
Copy link

Expected behavior

A building that I tag with the lifecycle-prefix abandoned should still be on the map after re-rendering.

Actual behavior

A building tagged with abandoned disappears from the map.

Further explanation and argumentation

I absolutely see the arguments made in #2551 and before that rendering abandoned waste baskets and other obsolete things bloats the map.
My main problem why I am opening this issue is that the standard rendering for a building is an accurate representation, even if it is abandoned. Where I live, there are lots of abandoned industrial buildings, and when I tag them as abandoned, they disappear from the map. So now, where in reality are massive amounts of huge buildings, there are just huge empty spaces on the map, wich is just not a representation of reality. And simply not removing a building wich is facutally there does not bloat the map.

@HolgerJeromin
Copy link
Contributor

abandoned prefix on building tag seems fishy.
A shop or office can be abandoned, but IMO no osm building. The feature (which is described by building tag) is still there.

@imagico
Copy link
Collaborator

imagico commented Oct 28, 2020

In principle i would support the rendering of abandoned buildings in a state of serious decay in a distinct rendering and the rendering of disused buildings without serious decay like normal buildings.

But we do not have a clear consensus on tagging among mappers apparently. The use of abandoned:building - while it seems to be the most widespread tag - is currently undocumented and as @HolgerJeromin says its exact meaning is not intuitively clear. Drawing a clear line between abandoned:building and disused:building is also missing, the generic explanation for the prefix is not really that helpful for the specific case of buildings.

@jeisenbe
Copy link
Collaborator

There is not clear consensus about whether building=* + abandoned=yes is prefered, or abandoned:building=*, and the situation for building=* + disused=yes vs disused:building=* is even less in favor of the namespaced version.

See previous general discussion at #2124 as well.

I don’t think we should support the tag abandoned:building until it is clearly defined and there is clear consensus that this method of tagging is preferrable to adding abandoned=yes.

It will also be difficult to find a rendering style for ruins and abandonded buildings. See previous efforts to define a different rendering for “minor buildings” at #3679 - We would need a clear idea of how to distinguish these features from other buildings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buildings declined new features Requests to render new features
Projects
None yet
Development

No branches or pull requests

5 participants