Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amenity=arts_centre name is not displayed area #4192

Closed
olo81 opened this issue Aug 18, 2020 · 7 comments
Closed

amenity=arts_centre name is not displayed area #4192

olo81 opened this issue Aug 18, 2020 · 7 comments

Comments

@olo81
Copy link

olo81 commented Aug 18, 2020

Expected behavior

name display

Actual behavior

when amenity = arts_centre is not pinned to a terrain only building no name is displayed

Links and screenshots illustrating the problem

https://www.openstreetmap.org/way/431050062
https://www.openstreetmap.org/way/784039349

@imagico
Copy link
Collaborator

imagico commented Aug 18, 2020

Your issue is a bit cryptic - as it is i am inclined to close it as invalid - rendering of amenity=arts_centre was added in #2520 (against opposition i would add - candidate for #3977) and polygon fill rendering was added in #2994.

If you have a different thing in mind please clarify.

@olo81
Copy link
Author

olo81 commented Aug 18, 2020

polygon fill rendering does not add a name
https://www.openstreetmap.org/way/784039349

@imagico
Copy link
Collaborator

imagico commented Aug 18, 2020

As linked to labels are rendered for amenity=arts_centre - why it does not show up in this particular case i don't know. Possibly the oneway arrow on the road is blocking the label here - that would make it a duplicate of #2429.

@olo81
Copy link
Author

olo81 commented Aug 18, 2020

I changed the name of this report to check which one is actually displayed

https://www.openstreetmap.org/relation/2003527

@olo81
Copy link
Author

olo81 commented Aug 19, 2020

"As linked to labels are rendered for amenity=arts_centre - why it does not show up in this particular case i don't know. Possibly the oneway arrow on the road is blocking the label here - that would make it a duplicate of #2429."

so that was it, the name appeared

@mboeringa
Copy link

mboeringa commented Aug 19, 2020

I changed the name of this report to check which one is actually displayed

https://www.openstreetmap.org/relation/2003527

Just a side note, but be aware that type=site relations, as the one you linked here, are handled by almost no OpenStreetMap software.

type=site relations are poorly defined geometrically, and a container for nodes, ways and other relations. As such, it is technically virtually impossible to do something sensible with it in rendering, and vital tools like osm2pgsql ignore them.

To be honest, I personally would drop the https://www.openstreetmap.org/relation/2003527 in favor of the much simpler closed way that is already present https://www.openstreetmap.org/way/431050062 with the same amenity=arts_centre and even more extended tagging, as there are now duplicate references to what is essentially the same thing. And every reasonable person understands that all buildings within the closed way belong to the facility / arts_centre, so no real need for the added complexity of a type=site relation.

As to type=site relations, I only see them as a kind of "administrative" tool, to group disparate stuff together, especially disjunct (e.g. multiple campuses of a single university), allowing you to navigate them on the OpenStreetMap website by clicking the hyperlinks of the linked objects, but nothing else.

@imagico
Copy link
Collaborator

imagico commented Aug 19, 2020

You should of course not remove correct tagging in the data to circumvent problems with the rendering here. In any case - this is the same problem as #2429 so closing as duplicate. Thanks for pointing out this also occurs with symbol labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants