Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render wetland=saltmarsh with a fill color #3799

Closed
jeisenbe opened this issue Jun 7, 2019 · 5 comments · Fixed by #3807
Closed

Render wetland=saltmarsh with a fill color #3799

jeisenbe opened this issue Jun 7, 2019 · 5 comments · Fixed by #3807

Comments

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jun 7, 2019

  • Unlike most wetlands, wetland=saltmarsh has only a pattern with no fill
  • This is the same situation as with wetland=mangrove and wetland=reedbed; all 3 features currently have no fill, because when we used land polygons the ocean and water fill colors were rendered below landcover, and these features can be found outside of the coastline or over water areas.
  • There are issues for the two other features requesting a color fill rendering: Render reedbed with a non-transparent color #2013 and Render wetland=mangrove with dark green fill #2025
  • This new issue is created so that all 3 features can have a color fill added, now that the oceans and water areas are rendered above landcover
  • Now, if wetland=saltmarsh is drawn outside of the coastline it will continue to have a blue, ocean color fill; the fill color would only be seen when the feature is over land.
  • It is suggested that wetland=saltmarsh could have the same color as wetland=marsh, or a similar color
@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Jun 7, 2019

Test renderings - Delaware

Before: current rendering of saltmarsh without fill color

z14 Delaware seashore - saltmarsh at center (park and residential fill shows), wetland=marsh with fill on left
z14-delaware-seashore-marsh-before

14 Salt marsh islands on right and upper left
z14-burton-island-marsh-before

z14 - Salt marsh on left, Dodd marsh on right is wetland=marsh
z14-dodd-marsh-saltmarsh-before

Test 1: Saltmarsh with @grass fill - #cdebb0

  • same as wetland=marsh, wetland=fen and wetland=wet_meadow

z14 @grass - Delaware seashore - saltmarsh at center (park and residential fill shows), wetland=marsh with fill on left
z14-delaware-seashore-saltmarsh-grass-fill-after

z14 @grass - Salt marsh islands on right and upper left
z14-burton-island-saltmarsh-after

z14 @grass - Salt marsh on left, Dodd marsh on right is wetland=marsh
z14-dodd-marsh-saltmarsh-after-grass-fill

Test 2: Saltmarsh with @campsite fill - #def6c0

z14 @campsite - Delaware seashore - saltmarsh at center (park and residential fill shows), wetland=marsh with fill on left
z14-delaware-seashore-saltmarsh-campsite-color

14 @campsite - Salt marsh islands on right and upper left
z14-burton-island-saltmarsh-campsite-fill

z14 @campsite - Salt marsh on left, Dodd marsh on right is wetland=marsh
z14-dodd-marsh-saltmarsh-campsite-fill

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Jun 7, 2019

Zeeland, Netherlands saltmarshes

A. Large salt marsh with many large tidal channels
https://www.openstreetmap.org/#map=13/51.3590/4.1393

B. 2 small salt marshes: one over sea water, one over land in database
https://www.openstreetmap.org/#map=15/51.4552/3.6555

0) Before

A. z13
z13-verdronken-saltmarsh-before

B. z15
z15-slufter-saltmarshes-zeeland-before

1) Saltmarsh with @grass fill - #cdebb0

A. z13
z13-verdronken-saltmarsh-grass-fill

B. z15
z15-slufter-saltmarsh-grass-fill

2) Saltmarsh with @campsite fill - #def6c0

A. z13
z13-verdronken-saltmarsh-campsite-fill

B. z15
z15-slufter-saltmarsh-campsite-fill

@jeisenbe
Copy link
Collaborator Author

As @imagico suggested in #2025 here are test renderings of saltmarsh with @grass fill - #cdebb0 plus a dot pattern suggestive of saltwater.

0) Current rendering for comparison:

A. Salt marsh (left) and marsh (right)
https://www.openstreetmap.org/#map=13/51.3590/4.1393
z13-schelde-saltmarsh-vs-marsh-before

B. Small salt marshes: one over sea water, one over land in database
https://www.openstreetmap.org/#map=15/51.4552/3.6555
z15-slufter-saltmarshes-zeeland-before

C. Saltmarsh (left) next to marsh (center), mouth of the Eel river, California
z14-eel-river-saltmarsh-marsh-before

1) Saltmarsh with dense dot pattern and @grass fill - #cdebb0

  • This dot pattern is copied from the saltwater pattern in the alt-colors style (water_salt.svg), changed to white
  • However, it may be too dense, covering up too much of the grass color

A.
z13-schelde-saltmarsh-vs-marsh-dots1

B.
z15-slufter-saltmarsh-dots1

C.
z14-eel-river-marsh-saltmarsh-dot1

2) Saltmarsh with looser dot pattern and @grass fill - #cdebb0

A.
z13-schelde-saltmarsh-dots2

B.
z15-slufter-saltmarsh-dots2

C.
z14-eel-river-marsh-saltmarsh-dot2

I believe this second pattern works well.

@jragusa
Copy link
Contributor

jragusa commented Jun 18, 2019

Why not replacing blue lines by white lines or even a mix of both lines ?

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Jun 18, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants