Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescale z_order and treat links the same as base type #3719

Closed
pnorman opened this issue Mar 16, 2019 · 6 comments
Closed

Rescale z_order and treat links the same as base type #3719

pnorman opened this issue Mar 16, 2019 · 6 comments
Assignees

Comments

@pnorman
Copy link
Collaborator

pnorman commented Mar 16, 2019

Currently all orders are divisible by 10. The z_order would be easier to work with if all current orders were divided by 10.

At the same time, we should make highway=X and highway=X_link have the same z_order, then add link status to the order by in the queries.

@pnorman pnorman self-assigned this Mar 16, 2019
@sommerluk
Copy link
Collaborator

we should make highway=X and highway=X_link have the same z_order, then add link status to the order by in the queries.

What would be the advantage of this change?

@pnorman
Copy link
Collaborator Author

pnorman commented Mar 20, 2019

What would be the advantage of this change?

Without an increase in query complexity it gives us more flexibility, cleaner z_order selection, and is clearer as why the values are different. It allows foo and foo_link to be treated the same which right now is not true.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Apr 9, 2019

This has to be done at the time of database reload, correct?

@pnorman
Copy link
Collaborator Author

pnorman commented Apr 9, 2019

This has to be done at the time of database reload, correct?

Yes

@jeisenbe
Copy link
Collaborator

jeisenbe commented Mar 7, 2020

The z_order would be easier to work with if all current orders were divided by 10.

I could still do this in #4055, though it will require changing more values, since the construction= values need 18 unique numbers.

Is that worthwhile?

@pnorman
Copy link
Collaborator Author

pnorman commented Mar 7, 2020

Thinking about this, it's not going to work with our peculiar ordering of links between high-class roads and low-class roads.


I could still do this in #4055, though it will require changing more values, since the construction= values need 18 unique numbers.

Is that worthwhile?

No.

@pnorman pnorman closed this as completed Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants