Release v4.2.0

[kocio-pl]

We could release v4.2.0 about the end of the month. The big news will be probably midzoom changes, but maybe some other visible stuff like railway names and leaf_type rendering will be ready to merge too.

[pnorman]

It'd be good to get some changelog updates committed first

[kocio-pl]

Of course, I can do it soon.

I'm more concerned with patterns issues, like #2737. Should we for example revert vector quarry pattern or there's another solution we could try?

[kocio-pl]

With new sanitizing code quarry can be fixed, but still we should know what to do with 512 px patterns? Do we accept them or we plan to move to 256 px with 4.2.0?

[kocio-pl]

This release will be loaded with changes, so I wait mainly for better 256 px SVG patterns to be fixed (if it's still the case) and merged - probably @imagico should check them, because he has the most issues with patterns in general.

We don't have to wait longer than that (it will be standard "2-5 weeks" cycle for a minor version change anyway). I keep the changelog updated, it's good to remember we should also update preview image this time to reflect water color change.

Any comments about that?

[matthijsmelissen]

+1

[kocio-pl]

With #2769 ready to be merged (I just wait if there are no further roads tuning) we wait for an opinion on:

• Dummy geometry for scrub pattern compatibility #2748 - scrub pattern fix
• Fixing quarry vector pattern #2760 - quarry pattern fix

@imagico, could you look at them and tell if it's safe to merge them or something should be fixed?

Some other PNG->SVG pattern transitions (#2749 - vineyard, #2759 - plant nursery) are not important to merge before v4.2.0, they are just regular PRs to check.

[imagico]

#2748 - scrub pattern fix
#2760 - quarry pattern fix

I have now commented on both of these but as i also clearly said in #2727 (comment) i think SVG patterns are not ready for production use here due to the rendering issues observed. Due to the special situations the quarry pattern does not appear to be affected by this so yes, you can probably safely merge that without making anything worse.

[sommerluk]

I agree that it’s better to use PNG pattern when SVG patterns have rendering problems.

I think that, as best practice, nevertheless

• the patterns should be generated by jsdotpattern
• the hole command sequence should be documented somewhere
• the sanitized SVG should be available in the “generate_patterns” folder
• the PNG used in production use should be a direct rendering of the SVG file in “generate_patterns”

This would make it easy to switch to SVG patterns if #2750 can be solved. And it would make it easy for forks to make different choises.

As @imagico said here:

until #2750 is solved i would suggest to stick to PNG patterns for anything with transparency or partial pixel coverage.

So I guess when there is no transparency/partial pixel coverage (patterns with opaque background), everything is fine (but currently there is no such pattern in this style).

[imagico]

So I guess when there is no transparency/partial pixel coverage (patterns with opaque background), everything is fine (but currently there is no such pattern in this style).

Orchard and plain wetland fall under this IIRC.

[kocio-pl]

I think fixing also #2771 (though it's a different problem) would be good before release.

[kocio-pl]

So the plan with patterns before new release is (I guess):

• merge Fix plant_nursery pattern #2773 (plant_nursery - if it's OK)
• revert Switch sand and wetland patterns to SVG #2727 (wetland and sand)
• close Switch vineyard to SVG #2749 (vineyard)

Orchard, vineyard and plant_nursery are gamma-bug safe, because they all are still in PNG format.

Is this all for now, @imagico?

[imagico]

Is this all for now, @imagico?

I always try to assume good faith but i honestly can't tell if you are mocking me here or if you are serious.

You do not seriously need me to tell you which patterns are currently using SVG files?

[kocio-pl]

Well, I just guessed you mean only gamma-related SVGs. Do you mean reverting all the SVG patterns - or what?

[kocio-pl]

I think it's about time to release. Unimportant roads are no longer white, so the only unclear thing left are SVG patterns at the moment. I'm very bad at guessing what exactly Christoph wants to do with them, but:

• without Fix plant_nursery pattern #2773 there will be no change, so we can decide it later
• Switch vineyard to SVG #2749 is closed now
• Switch sand and wetland patterns to SVG #2727 is ready to be reverted any time (I plan to do it tomorrow if nobody has better idea)
• polygon-pattern-gamma is also related to danger and graveyard patterns, but there were other issues with them before (PolygonPatternSymbolizer metatile alignment #937), so it would be only trading one problem for another
• forest is still 512 px big (so PolygonPatternSymbolizer metatile alignment #937 still applies), there are just more symbols now

I think there are no outstanding problems that could result in a bugfix version (v4.2.x), but I plan to wait just another day just to make sure. Please report if you see something that needs fixing now, otherwise we can try to solve it later.

[kocio-pl]

Released:

• New openstreetmap-carto release, v4.2.0 openstreetmap/chef#127
• http://www.openstreetmap.org/user/kocio/diary/42143