Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relation landuse=forest green under leisure park render. #2641

Closed
AllroadsNL opened this issue May 24, 2017 · 10 comments
Closed

Relation landuse=forest green under leisure park render. #2641

AllroadsNL opened this issue May 24, 2017 · 10 comments

Comments

@AllroadsNL
Copy link

forest relation

situation

The relation multipolygon landuse=forest should be rendered above the leisure park?
The tree icons are rendered above.
When a polygon landuse=forest is made, it is above the leisure=park.

forest relation polygon

@imagico
Copy link
Collaborator

imagico commented May 24, 2017

You need to be clearer on what you think the problem is.

In the area you link to i see nothing wrong with the rendering - although the mapping looks fairly chaotic.

For information: The area fills are rendered in order of the polygon sizes with the largest first and the smaller ones above. This might be confusing if you don't know it.

@AllroadsNL
Copy link
Author

In the area you link to i see nothing wrong with the rendering - although the mapping looks fairly chaotic.

The link of the situation, the mapping was changed to polygon landuse=forest, this is now the second image.

For information: The area fills are rendered in order of the polygon sizes with the largest first and the smaller ones above. This might be confusing if you don't know it.

This explains it, the multipoygon was bigger then the leisure polygon, but i think, leisure=park should be rendered under the landuse=forest.

Mostly people want to see the park name in the map. Not a boundary of the park.

A park include all kind of landuses and waters etc., now maybe more and more landcover is used.

@imagico
Copy link
Collaborator

imagico commented May 24, 2017

Closing this since there does not seem to be any specific suggestions on what should be changed except

leisure=park should be rendered under the landuse=forest

As said we order by polygon size, not by area type. If you have a forest polygon that is smaller than the park it is drawn above, if it is larger it is drawn below with the base color, the pattern is always drawn above.

@imagico imagico closed this as completed May 24, 2017
@SK53
Copy link

SK53 commented Jul 12, 2017

This may be the same or similar problem.

User Breau reported natural=wood rendering in two different colours for Odell Park, Fredricton, NB, Canada, screengrab:

screenshot 63

I downloaded area an checked for anomalies with JOSM validator, but no serious issues. Given that the paler green was parkland colour I immediately suspected this to be the wood fill being rendered under the park. Originally woodland was mapped as one large MP covering the majority of two parks (Odell Park & the Botanical Gardens).

To test this I split the original MP along the borders of the park to create 4 elements:

  • Woodland associated with Odell Park: the original MP 7347445
  • Woodland associated with Fredericton Botanical Gardens as an MP relation
  • 2 parcels of wood outside the parks, remapped as simple polygons

The woodland colour then renders correctly over the parkland.

odell_park_fixed

Naively I'd assume that park should (could?) always be rendered beneath wood/forest. The situation where a park borders a much large woodland which dips toes into the park is not that uncommon.

Anyway even if you wish to keep the issue closed: this note shows at least one workaround which may be appropriate in other situations.

@imagico
Copy link
Collaborator

imagico commented Jul 12, 2017

Yes, that is the expected behavior. I doubt we are going to change this principle but why do you assume parks would be rendered beneath wood/forest? Is it because what defines a park is something more abstract, less concrete than what a wood/forest is?

Someone less interested in botany and more focused on social and cultural aspects might assume the exact opposite.

If there is a logical and objectively justifiable order of different landcover features we could use that instead of size but at the moment i don't see this being the case.

@dieterdreist
Copy link

dieterdreist commented Jul 12, 2017 via email

@imagico
Copy link
Collaborator

imagico commented Jul 12, 2017

To clarify: landcover features was used here to refer to the features rendered in the landcover layer. No particular meaning of the term was implied.

Separating the current landcover features into different layers would also mean defining a rendering order since one layer is always rendered above the other.

@SK53
Copy link

SK53 commented Jul 12, 2017

Actually it's entirely because of social/cultural aspects, at least for urban parks, such as on a day like today: "is there any shade in park X?". There may also be cultural assumptions based on familiarity with classic english parks which rely on scattered trees, groves and patches of woodland to achieve their effect. However, for the same reasons I think it's entirely reasonable to do what I did for Odell Park and separate the woods in the park from adjacent woodland. They are likely to have different access arrangements, different amenity value, and (only now wearing a botanical hat) management and ground cover. So in other words, one can justify editing elements to make them render as desired under this regime on the basis that one is likely to be reflecting reality, and thus there is no need to change the style.

It would be an interesting exercise to identify places, or through thought experiments where the opposite applies.

On your last point, when I looked at Urban Atlas and OSM I managed with an explicit ordering of landuse features (as defined by UA). I dont know if I still have my mapnik stylesheet for the same.

@imagico
Copy link
Collaborator

imagico commented Jul 12, 2017

Well - the question is of course always if it is actually correct to map both a park and a wood forest here separately in light of One feature, one OSM element. But this is of course a fairly theoretical question since a park will rarely have completely homogeneous vegetation. You are probably right that the trees in the park can well be understood to constitute a wood/forest separate from the trees outside so can well be mapped separately.

For info: if the same feature is tagged both leisure=park and landuse=forest it is (based on my interpretation of the code, i have not checked) rendered as forest. If it is tagged leisure=park and natural=wood it should be rendered as park but with wood symbols. This is kind of strange and not really understandable for the map user - see also #1291.

@dieterdreist
Copy link

dieterdreist commented Jul 12, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants