Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render addr:unit on building entrances #2488

Closed
tpikonen opened this issue Dec 4, 2016 · 3 comments
Closed

Render addr:unit on building entrances #2488

tpikonen opened this issue Dec 4, 2016 · 3 comments

Comments

@tpikonen
Copy link
Contributor

tpikonen commented Dec 4, 2016

The recommended way of tagging staircases in apartment buildings is to use addr:unit (see: http://wiki.openstreetmap.org/wiki/Key:addr#Detailed_subkeys). This tag can be conveniently added to the entrance=staircase nodes on the building perimeter. Currently addr:unit is not rendered in the default OSM layer.

The Finnish OSM community currently has some momentum on improving addresses, but since addr:unit is not rendered, people have resorted to the incorrect method of using addr:housenumber on entrances.

The screenshot below, taken at http://www.openstreetmap.org/#map=18/60.15612/24.74071 shows two buildings of the same apartment complex, both with addr:housenumber=5. The building above is tagged correctly with addr:unit=C and D on main staircase entrances. The building below has entrances incorrectly tagged with addr:housenumber=5A (and 5B and 5C). By panning around in this area, one can see many examples of this incorrect tagging, made probably because it's the only way to make entrance addresses visible on the default map.

It would be really nice to have addr:unit tags on entrances rendered on higher zoom levels, perhaps one zoom level higher than when addr:housenumber becomes visible and with a slightly smaller font than addr:housenumber.

entranceunit

@kocio-pl kocio-pl added this to the New features milestone Dec 4, 2016
@nebulon42
Copy link
Contributor

I have not found addr:unit tags on the mentioned building. But anyway, yes I agree that it would be worthwhile to render addr:unit. I personally would require also the presence of addr:housenumber in addition to addr:unit. Else how do you know to which address the unit does belong to? That said I would extend the current rendering of addr:housenumber and addr:housename to also include addr:unitwhen present.

cc @sommerluk

@tpikonen
Copy link
Contributor Author

tpikonen commented Dec 5, 2016

The addr:unit tags in the top building are in the entrance nodes.

Rendering also addr:housenumber in the case of entrance=staircase nodes would lead to unnecessary clutter IMO, like in the lower building in the image, where the unit letter is added to addr:housenumber tag in the entrance to make it visible. If a building has an addr:unit tag, it would make sense to render it. Taginfo says that addr:unit is used on 180k nodes and only 20k ways, so there are not that many buildings with addr:unit tags. Not surprising, since units are usually staircases and other building-internal features.

The top building in the image below shows how to render addr:unit in entrances with (IMO) least clutter and most useful information.
entrancefix

@tpikonen
Copy link
Contributor Author

addr:unit is now rendered both on buildings and entrance nodes (and probably also everything else for that matter). The rendering has some problems as it is IMO, but I'll open another issue for those and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants