Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering both, addr:housename and addr:housenumber? #2328

Closed
sommerluk opened this issue Sep 5, 2016 · 6 comments
Closed

Rendering both, addr:housename and addr:housenumber? #2328

sommerluk opened this issue Sep 5, 2016 · 6 comments

Comments

@sommerluk
Copy link
Collaborator

In #2298 there was also a discussion about cases where addr:housename and addr:housenumber coexiste. Currently, if both exist, we render only one of them.

There are about 278 000 objects with addr:housename in the database. About 56% of them have also addr:housenumber, this is a considerable part.

It might be possible to render in such cases both of them, with a line break as separator, like this:

addr:housenumber\n
addr:housename

Would this be desirable?

@neiljp
Copy link

neiljp commented Sep 5, 2016

If there is space (high zoom, or automatically determined), personally I would prefer parentheses or some other separator.
There was some talk elsewhere I remember regarding how to treat eg. petrol/gas stations, eg. with name (owner) vs operator vs brand, where something similar could also be done?

@nebulon42
Copy link
Contributor

To me this would be desirable. I have done that in a fork I made for myself to try things out: https://github.com/gmgeo/osm-carto-gmgeo/blob/master/addressing.mss

@sommerluk
Copy link
Collaborator Author

Related to #735.

@aceman444
Copy link

If addr:housename is on the whole building, there will probably be a 'name' of the same value. So addr:housename rendering would be duplication. If addr:housename is on a node inside that building, then again, the building would have a "name" of the same value so that one would be rendered and no need to duplicate it on every addr node (e.g. shops) in the building.

addr:housename referencing a value that is NOT a 'name' on some building (the one around the node) would look like a tagging/logic error.

Am I missing something?

@polarbearing
Copy link
Contributor

If addr:housename is on the whole building, there will probably be a 'name' of the same value.

No. addr:housename is part of the postal address and often used only for this purpose. So the name=* tag might be absent. It could also have a different value, e.g. a shop name="Mary's Lollipops" residing in addr:housename=Hazelbrook.

@aceman444
Copy link

Yes, so if the shop Mary's has the address "Hazelbrook, No. street X, Town Y", why would the house itself NOT be named Hazelbrook? I'd expect it to. Why would a shop tell via the address that it is in the "Hazelbrook house", if the building wasn't named as such? So I'd expect the building to have name="Hazelbrook". Yes, in this case you would not be able to put all the shop tags on the whole building.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants