Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels for railway=station areas not rendered #2097

Closed
planemad opened this issue Mar 25, 2016 · 17 comments
Closed

Labels for railway=station areas not rendered #2097

planemad opened this issue Mar 25, 2016 · 17 comments
Assignees
Labels

Comments

@planemad
Copy link

screenshot 2016-03-25 16 44 00

https://www.openstreetmap.org/way/66239966#map=17/10.99836/76.96558

The label only shows up if there is an additional building tag, but then one would have multiple stations if there are more than one entrance building.

@dieterdreist
Copy link

sent from a phone

Am 25.03.2016 um 12:18 schrieb Arun Ganesh [email protected]:

The label only shows up if there is an additional building tag, but then one would have multiple stations if there are more than one entrance building

+1, stations and buildings are different things and the building tag has nothing to do with an (active) train station, besides some people using it like this ;-)
Any train station will also have a part with rails and might have no building at all

@kocio-pl
Copy link
Collaborator

Subset of #2094.

@martinum4
Copy link

you are using the railway=station tag wrong, it is not intended for areas, just for nodes, it is intended to contain all i think what you want here is landuse=railway, it is rendered like an industrial area, for better instructions see: http://wiki.openstreetmap.org/wiki/File:A-simple-station.svg

@dieterdreist
Copy link

sent from a phone

Il giorno 24 apr 2016, alle ore 05:00, martinum4 [email protected] ha scritto:

you are using the railway=station tag wrong, it is not intended for areas, just for nodes,

no, using it on a node is very old, approximate style and an area is clearly better, as stations always do have a significant spatial extension.

it is intended to contain all i think what you want here is landuse=railway, it is rendered like an industrial area, for better instructions see:

landuse=railway is not for stations, it is for all areas with railway related use.

@matkoniecz
Copy link
Contributor

matkoniecz commented Apr 24, 2016

you are using the railway=station tag wrong, it is not intended for areas, just for nodes

In overhelming majority of cases tagging railway station as areas makes more sense than tagging as nodes. I am pretty sure that current tagging consesus is that railway=station on areas is a valid taging.

@matkoniecz
Copy link
Contributor

landuse=railway is not for stations, it is for all areas with railway related use.

To make it more clear: landuse=railway is not only for stations, it is for all areas with railway related use.

@martinum4
Copy link

Well, if you want to map it as a area then where do you draw the line where a station begins? at the first switch that is controlled from it? at the entry/exit signals? at the platforms?

@dieterdreist
Copy link

sent from a phone

Il giorno 24 apr 2016, alle ore 11:57, martinum4 [email protected] ha scritto:

Well, if you want to map it as a area then where do you draw the line where a station begins? at the first switch that is controlled from it? at the entry/exit signals? at the platforms?

this discussion does not belong here, please ask your questions on the tagging ML

@matkoniecz
Copy link
Contributor

matkoniecz commented Jun 17, 2016

I am confused. I wanted to fix it as short break from more complex things but I am missing something. Layer code is

  - id: "stations"
    class: "stations"
    name: "stations"
    geometry: "point"
    <<: *extents
    Datasource:
      <<: *osm2pgsql
      table: |-
        (SELECT
            way,
            name,
            railway,
            aerialway,
            CASE railway 
              WHEN 'station' THEN 1 
              WHEN 'subway_entrance' THEN 3
              ELSE 2
            END
              AS prio
          FROM planet_osm_point
          WHERE railway IN ('station', 'halt', 'tram_stop', 'subway_entrance')
            OR aerialway = 'station'
          ORDER BY prio
        ) AS stations
    properties:
      minzoom: 12
    advanced: {}
  - id: "stations-poly"
    name: "stations-poly"
    class: "stations"
    geometry: "polygon"
    <<: *extents
    Datasource:
      <<: *osm2pgsql
      table: |-
        (SELECT
            way,
            name,
            railway,
            aerialway
        FROM planet_osm_polygon
        WHERE railway IN ('station', 'halt', 'tram_stop')
          OR aerialway = 'station'
        ) AS stations_poly

with rendering in stations.mss, and I see no bug here (and I see no reason why https://github.com/gravitystorm/openstreetmap-carto/blob/master/stations.mss would treat polygons differently as far as labels are concerned).

@kocio-pl kocio-pl self-assigned this Dec 3, 2016
@kocio-pl
Copy link
Collaborator

kocio-pl commented Dec 3, 2016

This area is retagged as landuse=railway, so I guess this issue can be closed now if no other similar problems are found. Unless this tagging is reverted as misused, so we could look if the bug is still here.

@kocio-pl
Copy link
Collaborator

This bug is real - I've made a tuned import and there's no label really.

It also doesn't render area color - probably area=yes is needed, which should not be needed, since I can't think of linear station and wiki page makes it clear.

See also this example:
https://www.openstreetmap.org/way/114507529

@Tomasz-W
Copy link

Tomasz-W commented Jul 3, 2018

In both cases I can see a label
https://www.openstreetmap.org/way/66239966
or an icon with label
https://www.openstreetmap.org/way/114507529

@kocio-pl Is there still some issue?

@matkoniecz
Copy link
Contributor

https://www.openstreetmap.org/way/66239966

See tags (landuse=railway, not railway=station)

https://www.openstreetmap.org/way/114507529

Hm, this one may be viable example.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 3, 2018

I'm not sure right now, could someone check if the problem is still here, just in case?

@matkoniecz
Copy link
Contributor

I looked through PRs for now, I see nothing claiming to fix it.

Maybe it was fixed accidentally.

@Tomasz-W
Copy link

Tomasz-W commented Jul 3, 2018

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 3, 2018

OK, so I'm closing it - it might be reopened if we're wrong, of course. Thanks for testing!

@kocio-pl kocio-pl closed this as completed Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants