-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels for railway=station areas not rendered #2097
Comments
sent from a phone
+1, stations and buildings are different things and the building tag has nothing to do with an (active) train station, besides some people using it like this ;-) |
Subset of #2094. |
you are using the railway=station tag wrong, it is not intended for areas, just for nodes, it is intended to contain all i think what you want here is landuse=railway, it is rendered like an industrial area, for better instructions see: http://wiki.openstreetmap.org/wiki/File:A-simple-station.svg |
sent from a phone
no, using it on a node is very old, approximate style and an area is clearly better, as stations always do have a significant spatial extension.
landuse=railway is not for stations, it is for all areas with railway related use. |
In overhelming majority of cases tagging railway station as areas makes more sense than tagging as nodes. I am pretty sure that current tagging consesus is that railway=station on areas is a valid taging. |
To make it more clear: landuse=railway is not only for stations, it is for all areas with railway related use. |
Well, if you want to map it as a area then where do you draw the line where a station begins? at the first switch that is controlled from it? at the entry/exit signals? at the platforms? |
sent from a phone
this discussion does not belong here, please ask your questions on the tagging ML |
I am confused. I wanted to fix it as short break from more complex things but I am missing something. Layer code is - id: "stations"
class: "stations"
name: "stations"
geometry: "point"
<<: *extents
Datasource:
<<: *osm2pgsql
table: |-
(SELECT
way,
name,
railway,
aerialway,
CASE railway
WHEN 'station' THEN 1
WHEN 'subway_entrance' THEN 3
ELSE 2
END
AS prio
FROM planet_osm_point
WHERE railway IN ('station', 'halt', 'tram_stop', 'subway_entrance')
OR aerialway = 'station'
ORDER BY prio
) AS stations
properties:
minzoom: 12
advanced: {}
- id: "stations-poly"
name: "stations-poly"
class: "stations"
geometry: "polygon"
<<: *extents
Datasource:
<<: *osm2pgsql
table: |-
(SELECT
way,
name,
railway,
aerialway
FROM planet_osm_polygon
WHERE railway IN ('station', 'halt', 'tram_stop')
OR aerialway = 'station'
) AS stations_poly with rendering in stations.mss, and I see no bug here (and I see no reason why https://github.com/gravitystorm/openstreetmap-carto/blob/master/stations.mss would treat polygons differently as far as labels are concerned). |
This area is retagged as landuse=railway, so I guess this issue can be closed now if no other similar problems are found. Unless this tagging is reverted as misused, so we could look if the bug is still here. |
This bug is real - I've made a tuned import and there's no label really. It also doesn't render area color - probably area=yes is needed, which should not be needed, since I can't think of linear station and wiki page makes it clear. See also this example: |
In both cases I can see a label @kocio-pl Is there still some issue? |
See tags (landuse=railway, not railway=station) Hm, this one may be viable example. |
I'm not sure right now, could someone check if the problem is still here, just in case? |
I looked through PRs for now, I see nothing claiming to fix it. Maybe it was fixed accidentally. |
@kocio-pl |
OK, so I'm closing it - it might be reopened if we're wrong, of course. Thanks for testing! |
https://www.openstreetmap.org/way/66239966#map=17/10.99836/76.96558
The label only shows up if there is an additional
building
tag, but then one would have multiple stations if there are more than one entrance building.The text was updated successfully, but these errors were encountered: