Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop rendering historic=citywalls #1812

Closed
matkoniecz opened this issue Sep 4, 2015 · 3 comments
Closed

stop rendering historic=citywalls #1812

matkoniecz opened this issue Sep 4, 2015 · 3 comments

Comments

@matkoniecz
Copy link
Contributor

I am not sure is it a good idea to display historic=citywalls. Maybe it is expecting too much, but city walls may be mapped as building=*.

Current historic=citywalls rendering is not intuitive, especially in places with building=* - see http://www.openstreetmap.org/#map=19/41.90367/12.45770

selection_001

Citywalls are visible early but it is not clear what is represented

http://www.openstreetmap.org/#map=14/53.3186/13.8433

selection_001

see also #1333

@imagico
Copy link
Collaborator

imagico commented Sep 4, 2015

Actually the more common (19k vs. 6k uses) and more logical tagging is barrier=city_wall. A simple city wall, in particular a onesided, embankment-like one - like this, should not be mapped as a building.

@nebulon42
Copy link
Contributor

Related to #1333.

@dieterdreist
Copy link

I used to put both, barrier=city_wall and historic=citywalls, as its both in my case. There is also historic=city_gate http://taginfo.openstreetmap.org/tags/historic=city_gate (which would be nice to render the name btw.) --- barrier=city_gate is negligible. In past discussions the issue of historic citywalls that aren't a barrier now has been raised.

in my opinion we should render both tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants