Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bank and ATM color to @amenity-brown? #1642

Closed
kocio-pl opened this issue Jul 8, 2015 · 9 comments
Closed

Change bank and ATM color to @amenity-brown? #1642

kocio-pl opened this issue Jul 8, 2015 · 9 comments

Comments

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 8, 2015

I think bank and ATM should have the color of all other amenities. Yes, they are special somehow, but still they are more like amenity (or maybe closer to shop?), while I think black is better for generic things, like name=* on a building. I also think about displaying craft=* POIs, so less color diversity of POIs would be better.

bank-brown
atm-brown

It was first mentioned here.

@HolgerJeromin
Copy link
Contributor

seems ok. We could delete the whole variable @money-icon as it is not used after this change.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Jul 8, 2015

Sure, fixed now.

@matthijsmelissen
Copy link
Collaborator

Good idea, I'm slightly in favour the retail colour though.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Jul 8, 2015

That's how it would look like then:

bank-shop-saski
bank-shop-rotunda

@matkoniecz
Copy link
Contributor

I think that @amenity-brown is better - at least for me "bank is an amenity" makes more sense than "bank is a shop",

I prefer @amenity-brown to the current state and the current state to purple.

@matkoniecz matkoniecz added this to the Bugs and improvements milestone Jul 9, 2015
@matthijsmelissen
Copy link
Collaborator

@matkoniecz Giving banks the same colour as shops would make it easier to recognize entertainment areas versus retail areas though. Most of the brown icons are entertainment, and all of the pink items are shops. Banks fit rather in the latter category.

@matkoniecz
Copy link
Contributor

OK, I see that it would be nice. Anyway, I have no strong opinion here. I still slightly prefer brown - but current or purple also would be OK.

@kocio-pl
Copy link
Collaborator Author

Some amenities are for entertainment, but it's hardly their main function, because this category is far less strict than shops - with post office, town hall, police station, fire station, memorial or even courthouse.

The choice is not obvious, so I hope for some more opinions. However there's no hurry, because it's just a small tuning.

@rmikke
Copy link

rmikke commented Jul 16, 2015

I'm for @amenity-brown. It's not a shop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants