-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match POI label colour to background or icon colour? #1355
Comments
For me different colours for icon and text always looked strange and my first thought was that of a mistake. I think POIs should have a distinct colour so the last option has too low contrast for me. I'm not sure if changing the font size according to area size while the icon does not change has the desired effect, but I like the font more. But that's more a general dislike of the appearance of DejaVu Sans with a certain letter spacing. Briefly: I like the first version best. |
I personally find it most intuitive if the color of the icon and accompanying label match, like in examples 1, 3 and 4, as there can be little doubt the icon and label belong to each other, even with more labels and icons in the same location. Matching the color with background color, like in 4, may also be an option, however, you have to consider if you prefer icons with a similar function to have similar color, which may preclude matching with background, or give precedence to the background matching. So function versus consistency with background. |
Good points above. Another aspect is that if we keep the text color different from the icon color, the relation between the icon and the area is not clear. For example, in the first picture, it is not clear that the camp sites cover the entire green area - it might as well be a small camp site within a large grass field. In the last picture, it's much clearer that the camp site covers the whole area. |
+1 |
What may be misleading. Camp site may cover only part of meadow. Also, what about camp sites in different places where background will be different? |
Camp sites are always rendered green (with a darker green outline). There is no meadow or grassland in the picture above, the green comes from the camp site tag. If the camp site only covers part of a meadow, and it's tagged as an area, then the outline of the camping is still visible. If it's tagged as a point, using the blue icon might be better. |
I don't like 2, it looks odd. 4 might look better with more contrast, but I find it hard to look past that. |
I like the last version. Clear and sharp with the dark color, yet still recognizable green. |
In that case greenish icon is a good idea. The only problem is that it removes unification of colour for various accommodations (hotels, hostels, motels etc). I also like the last version. |
I agree. Another problem is that it's not clear how the label should be rendered on zoomlevels where the area is smaller. It probably doesn't look good if the label is larger than the area. |
I don't really have a strong opinion here - a few thoughts though:
|
@pnorman What is your opinion on the darker version? |
"Version with increased contrast" looks okay to me. I wouldn't go any lighter. |
Contrast version is better, but I don't get the whole issue. Blue is for all the "sleeping" amenities, why we want (misleading) green instead - just because it can usually be used on grass? I also don't understand the hospital case - we already display kind-of-reddish icon+label on the yellowish area. |
There is no grass in the above images. camping is both a sleeping amenity and a park amenity, which is a conflict between how we would colour it. |
What they mean is that all scaling names currently have text color based on the matching area, and when the colors would differs, as they do here or with hospitals, a decision would have to be made in one direction or the other. I'm all for scaling the names of such areas (It's been a personal peeve I've had with how hospital campuses look). I also agree that name and icon should be the same color, though I am somewhat of two minds as to whether the original color should be maintained or one that matches the background be used. I'm inching toward green text (I prefer the mid-dark to the darkest option, though) because
|
@matthijsmelissen @pnorman @kocio-pl @Circeus |
If there's anything left, please reopen it. |
Yes, we still haven't answered the initial question, namely which of the presented renderings is preferred. |
For some POI, it both makes sense to match the label colour to the background, and to match it to the icon.
Examples of such POI where this is currently an issue are camp site and playground. If we decide to render areas of hospitals etc., the same issue will arise for such POI.
What would be preferred? Here are a couple of examples for camp site. The first is the current rendering.
The text was updated successfully, but these errors were encountered: