Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change color tourism=attraction label and drop rendering of tourism=attraction areas #1047

Closed
matthijsmelissen opened this issue Oct 11, 2014 · 5 comments · Fixed by #1063
Closed

Change color tourism=attraction label and drop rendering of tourism=attraction areas #1047

matthijsmelissen opened this issue Oct 11, 2014 · 5 comments · Fixed by #1063
Assignees
@gravitystorm
Labels
amenity-points enhancement
Milestone
Bugs and improvem...

Comments

@matthijsmelissen
Copy link
Collaborator

The tourism=attraction label does not look very nice in many situations.
@matthijsmelissen
Copy link
Collaborator Author

Examples:

http://www.openstreetmap.org/node/2616212674#map=19/50.06166/19.92931
http://www.openstreetmap.org/node/274088761

@matthijsmelissen matthijsmelissen mentioned this issue Oct 11, 2014
Merged
@matkoniecz
Copy link
Contributor

Maybe we should drop rendering of tourism areas and revert to old style for labels? Rendering of tourism=attraction areas is not really useful in my experience.

@matthijsmelissen
Copy link
Collaborator Author

Yes, I would support that.

@matkoniecz matkoniecz changed the title Change color tourism=attraction label Change color tourism=attraction label and drop rendering of tourism=attraction areas Oct 13, 2014
@matkoniecz matkoniecz self-assigned this Oct 13, 2014
@matkoniecz matkoniecz mentioned this issue Oct 14, 2014
Merged
@matkoniecz matkoniecz added this to the Bugs and improvements milestone Oct 14, 2014
@dieterdreist
Copy link

2014-10-13 9:20 GMT+02:00 math1985 [email protected]:

Yes, I would support that.

+1. IMHO we could use tourism=attraction as an additional qualifier to
render the names of those features earlier, but it shouldn't be treated as
a feature on its own.

@matthijsmelissen
Copy link
Collaborator Author

@gravitystorm Do you agree with dropping tourism=attraction areas?

@jeisenbe jeisenbe mentioned this issue Dec 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gravitystorm gravitystorm

Labels
amenity-points enhancement
Projects
None yet
Milestone
Bugs and improvements
Development

Successfully merging a pull request may close this issue.

tourism=attraction - partially restore old label, stop rendering areas
4 participants
@gravitystorm @dieterdreist @matkoniecz @matthijsmelissen