-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Oracle connections without wallet #49753
base: master
Are you sure you want to change the base?
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Turns out some clients are surprisingly difficult to configure without the JDBC connection string. I've updated the PR to always show that as an option, even when all agents are new enough to support TCP-only mode. |
f3e8650
to
6147b1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I tested these combos manually with oracle db [Agent v16.4.0, v17.0.2, v17.0.0-dev] x [tsh v16.4.0, v17.0.0-dev]
where the dev builds were made with this PR + the e update.
All combos worked 👍
Thanks for approvals folks! Adding 'do-not-merge' for now, we need to time this PR well to ensure the version checks do the right thing. |
Overview
The change is backwards compatible. Depends on https://github.com/gravitational/teleport.e/pull/5623 on the db agent side.
The functional changes:
tsh
will show connection instructions that don't depend on Oracle wallet.UX
All new agents:
Some or all old agents:
The
--debug
messages will show agent counts and alternative connection strings:changelog: Support wider range of Oracle clients and simplified configuration.