[v15] MockedUnaryCall.then: Handle onrejected not being defined #43269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just copied stuff from the linked implementation of then.
ravicious
added
the
no-changelog
gzdunek
approved these changes
Jun 20, 2024
ravicious
commented
Jun 20, 2024
| try { | ||
| // Despite this being an error branch, it needs to use Promise.resolve. Otherwise we'd get | ||
| // uncaught errors. See https://www.promisejs.org/implementing/#then | ||
| return Promise.resolve(onrejected(this.error)); |
There was a problem hiding this comment.
Oh actually, it makes total sense that this needs to be Promise.resolve(onrejected(…)).
If you have something like this:
Promise.reject().then(() => { /* onfulfilled */ }, () => { /* onrejected */)and onrejected doesn't reject itself, the final promise you get is fulfilled, not rejected.
|
@ryanclark ping |
ryanclark
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a v16 feature, I discovered that
MockedUnaryCallbehaves incorrectly when returned from a non-async function (which should be perfectly valid) #43195 (comment).Since that PR won't be backported to v15, I'm pushing just this single fix to v15.
I copied the error branch implementation from https://www.promisejs.org/implementing/#then. It's like the second time I'm fixing this class that I wrote myself, hopefully this is the last time! 🤞