From 44e81f8cca805a8c4331f35e8f61e4e928c67072 Mon Sep 17 00:00:00 2001
From: Gus Luxton <gus@goteleport.com>
Date: Tue, 19 Apr 2022 13:00:17 -0300
Subject: [PATCH] docs: Don't lint external links when running in CI (#12058)

Original behaviour did not take effect in CI due to a different entrypoint.

This restores the original behaviour (which will link external links when using make -C build.assets test-docs) but disables the external linting in CI for reliability.

Updates #11940
---
 .cloudbuild/ci/doc-tests.yaml | 8 +++-----
 build.assets/Makefile         | 2 +-
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/.cloudbuild/ci/doc-tests.yaml b/.cloudbuild/ci/doc-tests.yaml
index 19928b9432dbd..b63204376c76a 100644
--- a/.cloudbuild/ci/doc-tests.yaml
+++ b/.cloudbuild/ci/doc-tests.yaml
@@ -1,11 +1,9 @@
 steps:
   - name: quay.io/gravitational/next:main
     id: docs-test
-    env:
-      - WITH_EXTERNAL_LINKS=true
     entrypoint: /bin/bash
     dir: /src
-    args: 
-      - -c 
-      - ln -s /workspace /src/content && yarn markdown-lint-external-links
+    args:
+      - -c
+      - ln -s /workspace /src/content && yarn markdown-lint
     timeout: 10m
diff --git a/build.assets/Makefile b/build.assets/Makefile
index 107b199f823da..41633b657ec6c 100644
--- a/build.assets/Makefile
+++ b/build.assets/Makefile
@@ -369,7 +369,7 @@ docsbox:
 .PHONY:test-docs
 test-docs: docsbox
 	docker run --platform=linux/amd64 -i $(NOROOT) -v $$(pwd)/..:/src/content $(DOCSBOX) \
-		/bin/sh -c "yarn markdown-lint"
+		/bin/sh -c "yarn markdown-lint-external-links"
 
 #
 # Print the Go version used to build Teleport.