Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label-Specific Login options for multi-role users #6822

Closed
deusxanima opened this issue May 11, 2021 · 3 comments · Fixed by gravitational/webapps#873
Closed

Label-Specific Login options for multi-role users #6822

deusxanima opened this issue May 11, 2021 · 3 comments · Fixed by gravitational/webapps#873
Assignees
Labels
c-10 Internal Customer Reference c-aw Internal Customer Reference c-bi Internal Customer Reference c-cro Internal Customer Reference c-jo Internal Customer Reference c-ju Internal Customer Reference c-nj Internal Customer Reference c-oo Internal Customer Reference c-tg Internal Customer Reference c-tr Internal Customer Reference feature-request Used for new features in Teleport, improvements to current should be #enhancements

Comments

@deusxanima
Copy link
Contributor

deusxanima commented May 11, 2021

What

If a user is assigned to multiple roles, each with separate logins specified in their respective role config file, when they use the Connect dropdown next to a server in the WebUI they see all of the login options from all of the roles instead of only seeing the label-specific login options. This can be confusing for customers who may have multiple roles assigned to them based on env labels, but where each role-given login is label-specific.

Example:

Role A:

  • can see nodes matching label "env: a"
    • matches ServerA
  • has login listed as "userA"

Role B:

  • can see nodes matching label "env: b"
    • matches ServerB
  • has login listed as "userB"

If a user logs into the proxy WebUI and assumes both roles when they click the Connect dropdown option next to ServerA they see both "userA" and "userB" as login options. Even though "userB" will not work in this case it is still confusing nonetheless, especially in clusters where users may have more than two roles simultaneously and hundreds if not thousands of nodes with different labels and login options.

How

If a user clicks the Connect dropdown option next to ServerA, they should only see the "userA" login option that was defined in that role.

Why

Customers with large networks and multiple role mappings have requested the feature.

gz#5440

@deusxanima deusxanima added feature-request Used for new features in Teleport, improvements to current should be #enhancements c-10 Internal Customer Reference labels May 11, 2021
@deusxanima deusxanima added the c-bi Internal Customer Reference label Jun 21, 2021
@deusxanima deusxanima added the c-aw Internal Customer Reference label Aug 20, 2021
@yjperez yjperez added c-ju Internal Customer Reference c-tr Internal Customer Reference labels Jan 12, 2022
@klizhentas
Copy link
Contributor

klizhentas commented Jan 20, 2022

When we display a page, we take current user context and filter all the nodes through logins in the role set and add logins to the nodes list that role set allows for each node.

With pagination it's possible now, so our fullstack team can take care of it.

@deusxanima deusxanima added the c-tg Internal Customer Reference label Jan 27, 2022
@Erick-Reyes Erick-Reyes added the c-cro Internal Customer Reference label Apr 13, 2022
@mcbattirola mcbattirola self-assigned this Jun 3, 2022
@WilliamLoy WilliamLoy added the c-oo Internal Customer Reference label Jun 3, 2022
@programmerq programmerq added the c-nj Internal Customer Reference label Jun 7, 2022
@mcbattirola
Copy link
Contributor

mcbattirola commented Jun 14, 2022

PRs merged on master.

Backport:

  • v9
    • teleport
    • webapps
    • webapps.e

@mcbattirola
Copy link
Contributor

FYI @AHARIC @WilliamLoy this got into teleport 10, it should be available in the next release

@pierrebeaucamp pierrebeaucamp added the blocked is blocked by another item - please include the blocker label Jun 21, 2022
@pierrebeaucamp pierrebeaucamp removed the blocked is blocked by another item - please include the blocker label Jun 24, 2022
@pschisa pschisa added the c-jo Internal Customer Reference label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-10 Internal Customer Reference c-aw Internal Customer Reference c-bi Internal Customer Reference c-cro Internal Customer Reference c-jo Internal Customer Reference c-ju Internal Customer Reference c-nj Internal Customer Reference c-oo Internal Customer Reference c-tg Internal Customer Reference c-tr Internal Customer Reference feature-request Used for new features in Teleport, improvements to current should be #enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants