Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow prompting for a custom reason on regular role requests #29475

Open
programmerq opened this issue Jul 24, 2023 · 4 comments
Open

Allow prompting for a custom reason on regular role requests #29475

programmerq opened this issue Jul 24, 2023 · 4 comments
Labels
access-requests c-mac Internal Customer Reference c-nt Internal Customer Reference feature-request Used for new features in Teleport, improvements to current should be #enhancements tsh tsh - Teleport's command line tool for logging into nodes running Teleport. ui ux

Comments

@programmerq
Copy link
Contributor

What would you like Teleport to do?

Enhance the functionality of the request_prompt field in role configurations. The request_prompt field should not only provide a prompt for roles with the request_access: reason option set, but also define a custom message instructing users what they need to include with their access request.

For example, given the following role:

expand: `request_prompt: Please enter the Ticket ID`
kind: role
metadata:
  name: example_role
spec:
  allow:
    request:
      roles:
      - example_role
  deny: {}
  options:
    request_prompt: Please enter the Ticket ID
version: v6

The web UI would output the reason in some way so the user can know what is expected of them.

image

It might even be ideal to prompt the user to rerun with --request-reason when requesting a role via tsh request create that has a prompt, but the user did not specify the reason.

What problem does this solve?

Currently, the request_prompt field is designed to prompt a message when the role also has the request_access: reason option set. The only time this comes up is when using the waiting room / Advanced RBAC feature where the request is created at login.

More specific user-guidance is still helpful for cases where the user is creating a request manually. It will reduce confusion on Teleport end users.

If a workaround exists, please include it.

There isn't really a good workaround-- The user would just need to know that their Teleport admins require a certain piece of information in the request reason field that is currently marked "(optional)" in the web ui.

@programmerq programmerq added feature-request Used for new features in Teleport, improvements to current should be #enhancements ux ui tsh tsh - Teleport's command line tool for logging into nodes running Teleport. access-requests c-nt Internal Customer Reference labels Jul 24, 2023
@ravicious
Copy link
Member

ravicious commented Dec 18, 2023

Duplicate of #9184? Though this ticket has much more in depth explanation.

@programmerq
Copy link
Contributor Author

It looks like that one is similar, but might be more about prepopulating a reason in the field based on a template. This issue is more about having a request reason/prompt for access requests outside the context of the waiting room feature.

@zmb3
Copy link
Collaborator

zmb3 commented Dec 13, 2024

@kopiczko did you end up addressing this in your recent work? I feel like I recall seeing that you were sending the reason prompt up to the web UI now.

@kopiczko
Copy link
Contributor

This was the issue I was regarding request reasons I was working on recently #20164. It was about marking reason as required for certain requests, but I wasn't touching request_prompt functionality.

@deusxanima deusxanima added the c-mac Internal Customer Reference label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
access-requests c-mac Internal Customer Reference c-nt Internal Customer Reference feature-request Used for new features in Teleport, improvements to current should be #enhancements tsh tsh - Teleport's command line tool for logging into nodes running Teleport. ui ux
Projects
None yet
Development

No branches or pull requests

5 participants