Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from aws-sdk-go to aws-sdk-go-v2 #14142

Open
12 of 44 tasks
lxea opened this issue Jul 6, 2022 · 2 comments
Open
12 of 44 tasks

Migrate from aws-sdk-go to aws-sdk-go-v2 #14142

lxea opened this issue Jul 6, 2022 · 2 comments
Labels
aws Used for AWS Related Issues. feature-request Used for new features in Teleport, improvements to current should be #enhancements

Comments

@lxea
Copy link
Contributor

lxea commented Jul 6, 2022

Both versions are currently used in teleport (join_ec2.go,lib/utils/ec2.go use v2), V1 should be migrated away from eventually

Docs for migration: https://aws.github.io/aws-sdk-go-v2/docs/migrating/

@lxea lxea added the feature-request Used for new features in Teleport, improvements to current should be #enhancements label Jul 6, 2022
@zmb3 zmb3 added the aws Used for AWS Related Issues. label Jul 6, 2022
@greedy52
Copy link
Contributor

greedy52 commented Jun 5, 2024

FYI, we use v1 interface for mocking in testing and we do common error casting using v1 types. Migrating DB access and discovery to aws-sdk-go-v2 requires great effort.

@zmb3
Copy link
Collaborator

zmb3 commented Jun 5, 2024

Acknowledged. We're going to need to do it anyway as v1 is going end of life and we have unnecessary binary bloat due to using both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Used for AWS Related Issues. feature-request Used for new features in Teleport, improvements to current should be #enhancements
Projects
None yet
Development

No branches or pull requests

3 participants