Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic apps with conflicting names are (nearly) silently ignored #10797

Closed
Tener opened this issue Mar 3, 2022 · 0 comments · Fixed by #10947
Closed

Dynamic apps with conflicting names are (nearly) silently ignored #10797

Tener opened this issue Mar 3, 2022 · 0 comments · Fixed by #10947
Assignees
@Tener
Labels
application-access feature-request Used for new features in Teleport, improvements to current should be #enhancements good-starter-issue Good starter issue to start contributing to Teleport good-to-have Not a blocker for the milestone, but good to have implemented

Comments

@Tener
Copy link
Contributor

Tener commented Mar 3, 2022

What

Display clear warning in logs when static app overrides dynamic app with the same name.

How

A proper warning should be issued, not only a debug log.

Why

When there is a conflict between statically defined apps and dynamically defined apps (resource-based), the static app wins. This is almost invisible, only single line in logs indicates that and only with --debug which is not recommended in prod setups. This is very easy to miss.

Mar 03 16:05:36 ip-172-31-27-191.eu-central-1.compute.internal teleport[3800]: 2022-03-03T16:05:36Z DEBU [APP:SERVI] awsconsole has different origin (dynamic vs config-file), not updating. services/reconciler.go:160

Workaround

None.
@Tener Tener added feature-request Used for new features in Teleport, improvements to current should be #enhancements good-starter-issue Good starter issue to start contributing to Teleport good-to-have Not a blocker for the milestone, but good to have implemented application-access labels Mar 3, 2022
@Tener Tener mentioned this issue Mar 8, 2022
Merged
@Tener Tener self-assigned this Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tener Tener

Labels
application-access feature-request Used for new features in Teleport, improvements to current should be #enhancements good-starter-issue Good starter issue to start contributing to Teleport good-to-have Not a blocker for the milestone, but good to have implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to warning in case of resource origin clash. gravitational/teleport
1 participant
@Tener