Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

[5.5.x] Bump Go version to 1.17.5 #2699

Closed
wants to merge 6 commits into from

Conversation

bernardjkim
Copy link
Contributor

Description

Bump go version to 1.17.5.

Go 1.14 adds -d=checkptr as a compile-time option for adding instrumentation to check that Go code is following unsafe.Pointer safety rules dynamically. This option is enabled by default (except on Windows) with the -race or -msan flags, and can be disabled with -gcflags=all=-d=checkptr=0.

This lead to failed test cases related to some older dependencies. Disabling the check for now.

Go 1.17 changed how filenames were parsed in multipart forms golang/go#45789. Filename no longer includes directory path in filename. dd03d1e adds a workaround to this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Internal change (not necessarily a bug fix or a new feature)

Linked tickets and other PRs

TODOs

  • Self-review the change
  • Perform manual testing
  • Address review feedback
  • Update upstream references / tags / versions after upstream PR merges (linked above)

Testing

  • Basic manual testing by installing a cluster and joining nodes.

@wadells
Copy link
Contributor

wadells commented Jan 31, 2022

We can probably close this, per 5.5's deprecation in #2719.

@wadells wadells deleted the bernard/5.5.x/go1.17.5 branch September 22, 2022 20:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants