Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize ETH addresses #39

Closed
myrho opened this issue Aug 18, 2022 · 3 comments
Closed

Normalize ETH addresses #39

myrho opened this issue Aug 18, 2022 · 3 comments
Assignees

Comments

@myrho
Copy link
Contributor

myrho commented Aug 18, 2022

Before insert, normalize ETH addressen (either lowercase or uppercase them).

@cybersec-code
Copy link
Contributor

Just to keep it in mind, a (common) way to validate ETH addresses is using the "mixed-case checksum address encoding" (https://eips.ethereum.org/EIPS/eip-55). Normalize ETH addresses would prevent addresses from being validated using this method.

@behas
Copy link
Member

behas commented Oct 7, 2022

I think in the tagpacks we should keep the addresses as they are (mixed case); but when ingesting ETH addresses into the tagstore, they should be automatically normalized to lower-case

@behas behas assigned cybersec-code and unassigned mdragaschnig Oct 7, 2022
@cybersec-code
Copy link
Contributor

ETH addresses are now normalized before insertion into the db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants