Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce new execute exports #4215

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Oct 6, 2024

operating on ValidatedExecutionArguments:

executeQueryOrMutationOrSubscriptionEvent() and
experimentalExecuteQueryOrMutationOrSubscriptionEvent()

motivation: allows library users/servers to make sure that documents contain necessary operation and that variables coerce, and then allow them to call an executor on those already validated arguments

motivation: missing piece necessary for really closing #3679

operating on `ValidatedExecutionArguments`:

`executeQueryOrMutationOrSubscriptionEvent()` and
`experimentalExecuteQueryOrMutationOrSubscriptionEvent()`

motivation: allows library users/servers to make sure that documents contain necessary operation and that variables coerce, and then allow them to call an executor on those already validated arguments
@yaacovCR yaacovCR requested a review from a team as a code owner October 6, 2024 12:31
@yaacovCR yaacovCR requested a review from JoviDeCroock October 6, 2024 12:31
Copy link

netlify bot commented Oct 6, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 69ccb0a
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/67028307391e1900085ede0d
😎 Deploy Preview https://deploy-preview-4215--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Oct 6, 2024

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR merged commit c075a89 into graphql:main Oct 7, 2024
21 checks passed
@yaacovCR yaacovCR deleted the add-new-exports branch October 7, 2024 11:09
@yaacovCR yaacovCR added the PR: feature 🚀 requires increase of "minor" version number label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature 🚀 requires increase of "minor" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants