Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit URL in documentation #3947

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Fix edit URL in documentation #3947

merged 2 commits into from
Aug 11, 2023

Conversation

benjie
Copy link
Member

@benjie benjie commented Aug 10, 2023

If you go to https://graphql-js.org/docs/tutorials/authentication-and-express-middleware and click Edit this page you'll be taken to https://github.com/graphql/graphql-js/edit/main/website/docs/docs/tutorials/authentication-and-express-middleware.md.
Instead you should be taken to https://github.com/graphql/graphql-js/edit/main/website/docs/tutorials/authentication-and-express-middleware.md - the docs/ in the edit URL is incorrect since Docusaurus already adds that for you.

@benjie benjie requested review from IvanGoncharov and saihaj August 10, 2023 06:47
@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit c4d1f48
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/64d488ff5bf81f00070d3821
😎 Deploy Preview https://deploy-preview-3947--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Hi @benjie, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@IvanGoncharov IvanGoncharov merged commit bd4a2ae into main Aug 11, 2023
@IvanGoncharov IvanGoncharov deleted the docs-edit-url branch August 11, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants