Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup sorting & building/extending schema #3939

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

IvanGoncharov
Copy link
Member

Switch from using JS object as a map to use proper ES6 Map It gave ~30% speedup in benchmark tests.

Build Schema from AST
  2 tests completed.

  local x 93.98 ops/sec ±0.38% x 3.74 MB/op (9 runs sampled)
  HEAD  x   123 ops/sec ±0.91% x 3.78 MB/op (9 runs sampled)

Switch from using JS object as a map to use proper ES6 Map
It gave ~30% speedup in benchmark tests.

```
Build Schema from AST
  2 tests completed.

  local x 93.98 ops/sec ±0.38% x 3.74 MB/op (9 runs sampled)
  HEAD  x   123 ops/sec ±0.91% x 3.78 MB/op (9 runs sampled)
```
@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Jul 21, 2023
@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit f4847a5
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/64ba4f3efbbc26000806ca1a
😎 Deploy Preview https://deploy-preview-3939--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@IvanGoncharov IvanGoncharov merged commit 3610786 into graphql:main Jul 25, 2023
@IvanGoncharov IvanGoncharov deleted the pr_branch branch July 25, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant