Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing the right functions in testUtils #3880

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

Cito
Copy link
Member

@Cito Cito commented Apr 8, 2023

The expectMatchingValues-test file should test the expectMatchingValues.

The expectEqualPromisesOrValues function is already tested in the expectEqualPromisesOrValues-test file.

@netlify
Copy link

netlify bot commented Apr 8, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 9965be7
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6431adb83141440008c6ae5f
😎 Deploy Preview https://deploy-preview-3880--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 8, 2023

Hi @Cito, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Apr 15, 2023
@IvanGoncharov IvanGoncharov merged commit e581cc6 into graphql:main Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants