Fully switch to ESM (scripts, tests, etc.) #3564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
3 tasks
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
May 28, 2022
Extracted from graphql#3564 Motivation: `__dirname` and `require.resolve` is CJS specific mechanism and we use them in multiple places. Even without ESM migration this function makes internal scripts more high-level and thus readable.
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
May 28, 2022
Extracted from graphql#3564 Motivation: `__dirname` and `require.resolve` is CJS specific mechanism and we use them in multiple places. Even without ESM migration this function makes internal scripts more high-level and thus readable.
IvanGoncharov
force-pushed
the
pr_branch
branch
from
fea1499 to
c80fe08
Compare
IvanGoncharov
force-pushed
the
pr_branch
branch
from
c80fe08 to
7b08a08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.