Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies in formatted types #4333

Open
Cito opened this issue Jan 25, 2025 · 0 comments
Open

Inconsistencies in formatted types #4333

Cito opened this issue Jan 25, 2025 · 0 comments

Comments

@Cito
Copy link
Member

Cito commented Jan 25, 2025

There are a couple of Formatted...Result types that don't seem to be used anywhere. Therefore, they are also not checked for consistency.

For instance, there is a FormattedCompletedResult, but not a FormattedPendingResult, and the definition of FormattedCompletedResult seems to be wrong, it should have an "id" instead of "path" and "label".

I can contribute a fix, but it's unclear to me what purpose these types have if they are not used or referenced anywhere.

Particularly, should FormattedCompletedResult be changed or simply removed and replaced with CompletedResult like PendingResult? Or should the Formatted... be aliases if they are the same as the unformatted types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant