Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for 'toConfig' functionality #1674

Closed
IvanGoncharov opened this issue Jan 18, 2019 · 4 comments
Closed

Add tests for 'toConfig' functionality #1674

IvanGoncharov opened this issue Jan 18, 2019 · 4 comments
Labels
chore help wanted

Comments

@IvanGoncharov
Copy link
Member

Just a reminder that I need to write a test for toConfig functionality but I don't mind if someone wants to help 😉
@IvanGoncharov IvanGoncharov added this to the v14.2.0 milestone Jan 18, 2019
@doniyor2109
Copy link

@IvanGoncharov Hi ✋. I want to help for this issue if you want)

@IvanGoncharov
Copy link
Member Author

@doniyor2109 Would be great 👍
Then you will have a few tests ready please open WIP PR so I can provide feedback early on.

@doniyor2109 doniyor2109 mentioned this issue Jan 22, 2019
Closed
8 tasks
@doniyor2109
Copy link

@IvanGoncharov I have opened PR and it contains first test. I have test equality of config values. Is there anything to add in this test?

@IvanGoncharov IvanGoncharov removed this from the v14.x.x milestone Aug 13, 2020
@yaacovCR yaacovCR mentioned this issue Oct 11, 2024
Merged
@yaacovCR
Copy link
Contributor

Closed by #4225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yaacovCR @IvanGoncharov @doniyor2109