Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.10.5 -> 0.11.x breaking change (field must be Output, got Connection) #1024

Closed
kamek-pf opened this issue Sep 3, 2017 · 5 comments
Closed

Comments

@kamek-pf
Copy link

kamek-pf commented Sep 3, 2017

Hi,

Not sure where to report this, but since swapping between graphql-js version fixes the problem I figured this is the right place.
We're using graphql-relay-js's Connections.
In graphql-js#0.10.5, everything works fine. After upgrading to graphql-js#0.11.x, I get the following error :

Error: Campaign.guestProfiles field type must be Output Type but got: GuestProfilesConnection.

Any idea what I might be missing ?

@Gregoor
Copy link

Gregoor commented Sep 16, 2017

And here I was thinking I've gone crazy. Now that I know that it's probably not me, I'll look for the bug.

@IvanGoncharov
Copy link
Member

@kamek-pf @Gregoor Usually issues like that happen when you have multiple versions of graphql-js. To find out which library depend on the older version of graphql-js you can run npm ls graphql.

@Gregoor
Copy link

Gregoor commented Sep 18, 2017

🙈 thanks lots Ivan! How could I forget that one. It didn't happen to me already a while ago.

Would it be possible to show a specific error when that happens?

@IvanGoncharov
Copy link
Member

@Gregoor There were a few attempts to make different versions of graphql-js compatible.
Here is the most recent one: #996

As for better error message, the only way to implement this correctly would be to check all input arguments of all public functions.

@leebyron
Copy link
Contributor

leebyron commented Dec 7, 2017

#1080 will dramatically improve this error message. Some PRs partly implementing it are already going up. Sorry for the confusion and happy to hear your problem was solved.

@leebyron leebyron closed this as completed Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants