Avoid creating new tabs on header state #3371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3c2b436 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Solves #2825, an old bug where new tabs were created on every refresh the bug occurred when: 1. `shouldPersistHeaders` is not set to true 2. `headers` or `defaultHeaders` are provided as props 3. the user refreshes the browser
acao
force-pushed
the
2825-new-tab-headers
branch
from
19f2b70 to
3c2b436
Compare
|
The latest changes of this PR are available as canary in npm (based on the declared |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3371 +/- ##
==========================================
- Coverage 55.76% 55.75% -0.02%
==========================================
Files 110 110
Lines 5242 5243 +1
Branches 1425 1426 +1
==========================================
Hits 2923 2923
- Misses 1896 1897 +1
Partials 423 423
|
✅ Deploy Preview for graphiql-test ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2825, an old bug where new tabs were created on every refresh
the bug occurred when:
shouldPersistHeadersis not set to trueheadersordefaultHeadersare provided as propsI could not get cypress to re-create the bug, but I was able to manually confirm the fix