Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Questions about the parser implemented here. #888

Open
bd82 opened this issue Jul 13, 2018 · 2 comments
Open

Some Questions about the parser implemented here. #888

bd82 opened this issue Jul 13, 2018 · 2 comments

Comments

@bd82
Copy link

bd82 commented Jul 13, 2018

  • Why is a different parser used than the one implemented in graphql-js ?

  • Is a different data structure output produced?

  • Does this parser have error recovery and fault tolerance capabilities? (I have not found any).

Cheers.
Shahar.

@acao acao transferred this issue from graphql/graphql-language-service Jun 26, 2019
@Neitsch
Copy link
Contributor

Neitsch commented Jun 27, 2019

Hi @bd82 , I believe the parser is fault tolerant to provide such things as autocomplete after .... There's some issue floating around in the GraphQL repo to unify both parsers to be fault tolerant :)
Unfortunately I am not sure myself how the fault tolerance is implemented.

@bd82
Copy link
Author

bd82 commented Jun 27, 2019

Hello @Neitsch here is a link to the previous discussion, perhaps you are referring to it?

I have also POCed an advanced GraphQL parser ~1 year ago implemented using Chevrotain

What is the status nowadays? Particularly with the graphiql new project?
Are there things lacking in the IQL Parser? things that need to be improved? Are there Editor services capabilities that you want to be able to provide but are hitting a barrier due to parsing technology?

I am basically trying to understand if there is a reason to dust off / update / fix the "graphql-advanced-parser" I've created and attempt to integrate it into this project?

Cheers.
Shahar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants