feat: monaco-graphql docs, api, improvements #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acao
force-pushed
the
feat/monaco-docs-api
branch
2 times, most recently
from
f0edb38 to
6e4adba
Compare
- add more detailed `monaco-graphql` docs - move language worker to it's own file - new API class - configure schema options using API - configure formatting options (prettier!) using API - RuleKinds implemented further, improving parser DX - improve language service's schema loading mechanisms and API
acao
force-pushed
the
feat/monaco-docs-api
branch
from
6e4adba to
addce72
Compare
acao
force-pushed
the
feat/monaco-docs-api
branch
from
23af5ee to
c9000d1
Compare
|
@rebornix what do you think of the |
cshaver
reviewed
May 13, 2020
cshaver
reviewed
May 13, 2020
|
@cshaver can you confirm for posterity that you've given this a whirl locally and it all works? i recall you referring to something as such |
acao
force-pushed
the
feat/monaco-docs-api
branch
from
133ae69 to
b33edf9
Compare
Co-authored-by: Cristina Shaver <[email protected]>
acao
force-pushed
the
feat/monaco-docs-api
branch
from
b33edf9 to
c4f14af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are most of the monaco and LSP changes pulled from #1468. This will make #1468 a lighter PR and allow folks to keep moving this language mode forward as we deliberate on the new GraphiQL RFC
monaco-graphqldocsmonaco.languages.graphql.apiclasstypedocfor deploy preview/master build. just append/typedocto preview urlcaveats
monaco-yaml, we would need to be able to retrieve schema per file URI in the workspace, similar to how it's done with graphql config in the LSP server.links
monaco-graphqlreadmemonaco-graphql(API patterns are following the patterns used by other monaco modes, such as
monaco-json,monaco-typescript,monaco-html, etc)How to Demo:
examples/monaco-graphql-webpackyarn startOR
deploy preview url plus
/monaco