-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to [email protected] for #1191 #1204
Conversation
@Urigo so we are using when i print out the result of the introspection request, i get: |
ee6302e
to
6a327df
Compare
ardatan/graphql-tools#1 i think this is the right place? |
I think this was already fixed on tomorrow we'll make sure to have updated versions of it published |
00f36cc
to
933ea14
Compare
@Urigo everything looks good now, thank you! |
Codecov Report
@@ Coverage Diff @@
## master #1204 +/- ##
=======================================
Coverage 58.98% 58.98%
=======================================
Files 60 60
Lines 3023 3023
Branches 806 806
=======================================
Hits 1783 1783
Misses 1194 1194
Partials 46 46 Continue to review full report at Codecov.
|
@IvanGoncharov it's finally ready for you to review, what do you think? |
05f0b17
to
eaac853
Compare
@IvanGoncharov I think the only thing we missed here as a baseline is removing the peer dependencies on lower versions of graphql. We should only support 14 and 15 now correct? |
Have
[email protected]
working as a baseline, without necessarily adding support for new language features yet. Consequently, it requires an upgrade tographql-config-rc.2
. This is why we are still in alpha! Further PRs will follow that address things like interfaces implementing interfaces, etcinstrospectionQuery()
rather than constant (deprecated)graphql-config
and server tests? potentiallygraphql-config
is not working with 15.