Fix setImmediate and setTimeout issues #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1ru4l
approved these changes
Feb 18, 2022
saihaj
approved these changes
Feb 18, 2022
dotansimha
approved these changes
Feb 22, 2022
n1ru4l
approved these changes
Mar 14, 2022
|
Any plans to merge and publish this? |
Yes hopefully next week need to do some CI updates here to automate things |
|
@vdeantoni opened #301 so on its resolution I will setup changesets |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the browsers don't have
setImmediate.setImmediate || setTimeoutdoesn't work and it throwssetImmediate is not definedin this case, so we should checksetImmediatewithtypeof.And some environments like Cloudflare Workers don't allow you to set
setTimeoutdirectly to another variable.This PR fixes both of these issues.