Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ResultExt trait to replace the current From<Display> error #166

Closed

Conversation

kestred
Copy link
Contributor

@kestred kestred commented Apr 6, 2018

See the reasoning for this change in #157

@kestred
Copy link
Contributor Author

kestred commented May 27, 2018

Juniper team--- would very much like to get your comments on #157.

If you agree with this direction, I will happily rebase this branch on top of latest, add some tests for it, and make all the appropriate changes to docs and code.

@LegNeato
Copy link
Member

Is this obsoleted by f115d0b?

@kestred
Copy link
Contributor Author

kestred commented Jul 17, 2018

@LegNeato: Yes — at least for me — that change resolves my use cases for P.R. #166 and issue #157.

@kestred kestred closed this Jul 17, 2018
@kestred kestred deleted the kstenerson/result-ext branch August 15, 2018 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants