Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct pyproject.toml build-backend specification #118

Closed
nchepanov opened this issue Jan 20, 2021 · 3 comments
Closed

Correct pyproject.toml build-backend specification #118

nchepanov opened this issue Jan 20, 2021 · 3 comments

Comments

@nchepanov
Copy link

Currently:

[build-system]
requires = ["poetry>=1,<2"]
build-backend = "poetry.masonry.api"

According to https://python-poetry.org/docs/pyproject/#poetry-and-pep-517

If your pyproject.toml file still references poetry directly as a build backend, you should update it to reference poetry_core instead.

Should be updated to,

[build-system]
requires = ["poetry_core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

This will significantly speed up the package installation process, since the entire poetry dependency cone is currently being installed during isolated build per PEP517.

I can submit a PR if no objections.

@KingDarBoja
Copy link

Good catch, feel free to submit a PR 🚀

@Cito
Copy link
Member

Cito commented Feb 7, 2021

Thanks for reporting. This was fixed in add666f and will be available in the upcoming release (soon).

@Cito Cito closed this as completed Feb 7, 2021
@Cito
Copy link
Member

Cito commented Feb 8, 2021

Version 3.1.3 with this fix has now been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants