Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depending on unmaintained library aiodataloader #326

Closed
sebix opened this issue Dec 6, 2021 · 8 comments
Closed

Depending on unmaintained library aiodataloader #326

sebix opened this issue Dec 6, 2021 · 8 comments

Comments

@sebix
Copy link

sebix commented Dec 6, 2021

Unfortunately https://github.com/syrusakbary/aiodataloader looks unmaintained: Necessary fixes are not released, Maintainers do neither respond nor transfer permissions to others.
aiodataloader is "only" used in one place:

class RelationshipLoader(aiodataloader.DataLoader):

Please check if it's possible to remove this stale dependency or other alternatives.

@richin13
Copy link
Contributor

richin13 commented Dec 7, 2021

The whole ecosystem can be considered abandoned/unmaintained at this point, sadly.

@erikwrede
Copy link
Member

@richin13 is there anything we can do about it? Sad to see such a rich ecosystem go unmaintained with even simple fixes not being merged. I saw the call for maintainers on the main graphene repo, but even there only little activity seems visible.

@Cito
Copy link
Member

Cito commented Dec 25, 2021

@erikwrede @richin13 I don't think the whole ecosystem is abandoned, but parts of it are.

I see two core probems:

  1. We don't have a coordinater for the whole graphql-python system (anymore). There were some peole who volunteered, but life or job changes got in their ways. So we again need someone to volunteer as new overall coordinator and protagonist of the ecosystem.
  2. Some (not all) projects in the ecosystem are abandoned or unmaintained. We need more people who would be willing to act as maintainers and contact persons for one of these projects.

I don't think these problems are unsolvable. We just need a handful of reliable and comitted people who would not just offer help unspecifically, but really take responsibility as coordinator or maintainers. Then we could refloat the boat.

The reason for the sad state is that working as long-time maintainer of a project is a much more boring and thankless task than creating it once.

It would help if companies that are using the libraries would contribute by sponsoring the maintainers or engaging themselves in the long-time maintenance and coordination of the projects.

I you want to take over maintenance of a seemingly anandoned project, this is absolutely possible. First try to contact the authors and current maintainers. If they cannot be reached, you can request a name transfer, as explained here.

@richin13
Copy link
Contributor

richin13 commented Jan 5, 2022

@Cito agreed!
I didn't mean to generalize my concerns to all of graphql-python but to graphene specifically. I know the core libs are heavily maintained (thanks to you!) and actively used in other libraries beyond graphene.

As per your points, those are valid, I'd say we've done it but with no success. Maybe is a matter of pushing harder I don't know. I think people willing to jump in and contribute were slowly pushed away by the lack of interest from the people actually capable of transferring and approving new maintainers.

@palisadoes
Copy link
Collaborator

@Cito I'm interested in partially sponsoring work on graphene-sqlalchemy to integrate filters like graphene-sqlalchemy-filter. How should I proceed?

@Cito
Copy link
Member

Cito commented Mar 29, 2022

@palisadoes You can join the Graphene slack channel, maybe someone there is willing to work on this. There is a link on the Graphene home page.

@palisadoes palisadoes mentioned this issue Mar 30, 2022
@erikwrede
Copy link
Member

Seems like the library has a new maintainer, urgent fixes have also been pushed to PyPi:
syrusakbary/aiodataloader#20 (comment)

Closing this issue for now.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics referencing this issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants