-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrong import dependency version with new requests minor release 2.30.0 #412
Comments
Thanks for your report. The tests which were passing before are now failing (I tried to re-run all jobs on this previous test action on GitHub) The proper solution should be I think to restrict urllib3 to < 2 for now. |
Ah ok, I didn't test any other parts of the library. But simple gql requests where working for me with the new requests-toolbelt version. It is true that the error came from urllib3. An import error of urllib3.contrib.appengine. |
It is explained by the fact that requests_toolbelt added support to urllib3 v2 in its latest version. |
I fixed it in PR #413 |
Fixed in pre-release v3.5.0b4 and in bugfix release 3.4.1. |
Thanks for the quick release, already using it at work now! |
The new version of requests (2.30) has some breaking changes that prevent it working with requests-toolbelt <1.
It does work with version 1.0.0 of requests-toolbelt, so I suggest updating the setup.py requirements:
"requests_toolbelt>=0.9.1,<1",
into
"requests_toolbelt>=1.0.0",
I do not know if the new breaking changes affect any other parts of gql, so I am not directly putting in a merge request. Limiting requests to 2.29 is also a solution.
Kind regards and thanks for the nice library
The text was updated successfully, but these errors were encountered: