Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Parse methods #296

Closed
sungam3r opened this issue Apr 16, 2023 · 5 comments · Fixed by #306
Closed

More Parse methods #296

sungam3r opened this issue Apr 16, 2023 · 5 comments · Fixed by #306
Labels
enhancement New feature or request

Comments

@sungam3r
Copy link
Member 

          Just a note - it seems that we could make more methods public to allow parse concrete parts of document.

Originally posted by @sungam3r in #295 (comment)
@sungam3r sungam3r mentioned this issue Apr 16, 2023
Merged
@sungam3r sungam3r added the BREAKING Breaking changes in either public API or runtime behavior label Apr 16, 2023
@Shane32
Copy link
Member

Shane32 commented Apr 16, 2023

See:

@Shane32
Copy link
Member

Shane32 commented Apr 16, 2023

Public Parse<T> has been added; just needs someone to add a few lines of code for each ASTNode type, which will not change external API but will add functionality.

@Shane32 Shane32 added enhancement New feature or request and removed BREAKING Breaking changes in either public API or runtime behavior labels Apr 16, 2023
@sungam3r
Copy link
Member Author

Also add tests to cover all cases. I'm not sure there will be no issues. + deprecate non-generic Parse method, I think.

@Shane32
Copy link
Member

Shane32 commented Apr 16, 2023

I would not deprecate non-generic Parse method, but we could just => Parse<GraphQLDocument>(...)

The library's primary purpose is to parse GraphQL documents; all other types are niche cases.

@sungam3r
Copy link
Member Author

I'm fine either way.

@sungam3r sungam3r mentioned this issue Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to parse more AST nodes graphql-dotnet/parser
2 participants
@Shane32 @sungam3r