Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add receipts timeout config #537

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

rotarur
Copy link
Contributor

@rotarur rotarur commented Dec 9, 2024

This PR fixes this issue #532

I've tested the image by building it and pushing to docker hub.

This screenshot is without the config (failing):
Screenshot 2024-12-11 at 11 28 44

This screenshot is with the config (success):

[tap]
sender_timeout_secs = 120

Screenshot 2024-12-11 at 11 36 39

@coveralls
Copy link

coveralls commented Dec 9, 2024

Pull Request Test Coverage Report for Build 12263240895

Details

  • 5 of 7 (71.43%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 80.218%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/tap-agent/src/agent/sender_account.rs 1 2 50.0%
crates/tap-agent/src/agent/sender_accounts_manager.rs 2 3 66.67%
Totals Coverage Status
Change from base Build 12189697212: 0.02%
Covered Lines: 6829
Relevant Lines: 8513

💛 - Coveralls

@rotarur rotarur force-pushed the rotarur/fix-database-timeout branch 2 times, most recently from 43f6102 to 9ea6a45 Compare December 9, 2024 13:17
@rotarur rotarur force-pushed the rotarur/fix-database-timeout branch from 9ea6a45 to f03ccf4 Compare December 10, 2024 19:24
Copy link
Collaborator

@carlosvdr carlosvdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@carlosvdr carlosvdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlosvdr carlosvdr merged commit 2438895 into main Dec 11, 2024
10 checks passed
@carlosvdr carlosvdr deleted the rotarur/fix-database-timeout branch December 11, 2024 15:35
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants