Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch panics in query processing #805

Closed
leoyvens opened this issue Mar 7, 2019 · 0 comments · Fixed by #1448
Closed

Catch panics in query processing #805

leoyvens opened this issue Mar 7, 2019 · 0 comments · Fixed by #1448

Comments

@leoyvens
Copy link
Collaborator

leoyvens commented Mar 7, 2019

Using panics instead of errors for conditions that should never happen helps with surfacing bugs, but we'd not want a query that triggers a bug to crash an entire query node. So we should give special treatment to panics during query processing and so that a panic anywhere in the pipeline would be recovered from and a 500 response is returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants