Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-source crate dependency versions #4013

Closed
neysofu opened this issue Sep 30, 2022 · 5 comments
Closed

Single-source crate dependency versions #4013

neysofu opened this issue Sep 30, 2022 · 5 comments

Comments

@neysofu
Copy link
Member

neysofu commented Sep 30, 2022

Would be nice to use the workspace inheritance feature introduced with Rust 1.64 to provide a single source of truth for dependency versions.

Blocked by dependabot/dependabot-core#5315.

@poliorcetics
Copy link

I opened a PR for it dependabot/dependabot-core#5794, it should work but it's not merged yet.

It's probably possible to regenerate the docker container and use it locally to make the necessary changes but I have no idea how to do that. I'll gladly accept people testing it and telling me if it works has expected in a variety of configs though 👍

@neysofu
Copy link
Member Author

neysofu commented Oct 11, 2022

Thanks @poliorcetics! I see your PR got merged, nice! Is the feature available already, then?

@poliorcetics
Copy link

It should be. I found a bug, but the use case to encounter is not something I have seen in practice, you can try it out and see if you have no dependabot mrs anymore

@neysofu
Copy link
Member Author

neysofu commented Oct 11, 2022

Yeah, saw the new issue but that use case doesn't apply to us, so we're unblocked here. Thank you for the PR!

@neysofu
Copy link
Member Author

neysofu commented Oct 18, 2022

Closed by #4061.

@neysofu neysofu closed this as completed Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants