Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pausing test for should fail partial pause if not guardian or governor #856

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

Maikol
Copy link
Member

@Maikol Maikol commented Aug 30, 2023

There's currently two tests performing the same actions possibly due to a copy/paste error:

it('should fail pause guardian when not governor', async function () {
  const tx = controller.connect(me.signer).setPauseGuardian(guardian.address)
  await expect(tx).revertedWith('Only Governor can call')
})

it('should fail partial pause if not guardian or governor', async function () {
  const tx = controller.connect(me.signer).setPauseGuardian(guardian.address)
  await expect(tx).revertedWith('Only Governor can call')
})

From test title looks like the second one is meant to be testing that a non governor/guardian shouldn't be able to set partial pause status.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (013240a) 94.44% compared to head (4396fd9) 94.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #856   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files          49       49           
  Lines        2430     2430           
  Branches      436      436           
=======================================
  Hits         2295     2295           
  Misses        135      135           
Flag Coverage Δ
unittests 94.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tmigone tmigone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Maikol Maikol merged commit c501141 into dev Aug 30, 2023
6 checks passed
@Maikol Maikol deleted the mde/partial-pause-test branch August 30, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants