Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric names should support utf-8 #243

Closed
mleinart opened this issue Mar 14, 2013 · 7 comments
Closed

Metric names should support utf-8 #243

mleinart opened this issue Mar 14, 2013 · 7 comments

Comments

@mleinart
Copy link
Member

The first blocker to this is in the grammar with validMetriChars: https://github.com/graphite-project/graphite-web/blob/master/webapp/graphite/render/grammar.py#L52

The grammar should instead have a blacklisted set of characters used by the grammer itself (parenthesis, etc).

This is related to #242 in that the grammar changes are closely related

@davewongillies
Copy link

+1

@banzayats
Copy link

There is no validMetricChars in grammar.py, but webapp still doesn't work with utf8 characters.
Any news on this issue?

@nacyot
Copy link

nacyot commented Apr 29, 2014

+1

3 similar comments
@karmicnewt
Copy link

+1

@KevinJMao
Copy link

+1

@yinchuan
Copy link

+1

@stale
Copy link

stale bot commented Apr 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 14, 2020
@stale stale bot closed this as completed Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants