Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gather.initialState needs access to EXPORTABLE and sql #2248

Open
benjie opened this issue Nov 25, 2024 · 0 comments · May be fixed by #2250
Open

gather.initialState needs access to EXPORTABLE and sql #2248

benjie opened this issue Nov 25, 2024 · 0 comments · May be fixed by #2250
Labels

Comments

@benjie
Copy link
Member

benjie commented Nov 25, 2024

E.g. look at PgLtreePlugin - it had to import from graphile-build and pg-sql2 directly!

info.EXPORTABLE on helpers exists, but there's no sql equivalent. Helpers should be hookable, and we should have a helpers hook so that plugins can add stuff to helpers (like adding to build).

Alternatively, gather() should have access to Build... but if so, we need to rethink schema.hooks.build since it needs to exist before gather.

@github-project-automation github-project-automation bot moved this to 🌳 Triage in V5.0.0 Nov 25, 2024
@benjie benjie removed this from V5.0.0 Nov 25, 2024
@benjie benjie changed the title gather.initialState needs access to EXPORTABLE gather.initialState needs access to EXPORTABLE and sql Nov 25, 2024
@github-project-automation github-project-automation bot moved this to 🌳 Triage in V5.0.0 Nov 25, 2024
@benjie benjie linked a pull request Nov 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🌳 Triage
Development

Successfully merging a pull request may close this issue.

1 participant